'RE: [Video-dev] CR: bug 159898, assertion during video playback'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-video-dev
Subject:    RE: [Video-dev] CR: bug 159898, assertion during video playback
From:       Milko Boic <milko () real ! com>
Date:       2006-03-19 2:24:53
Message-ID: 6.2.1.2.2.20060318182344.03eb1700 () mailone ! real ! com
[Download RAW message or body]

Does this work if display properties (e.g. resolution) are changed in the 
middle of the playback?

At 04:48 PM 3/9/2006, Todd Zupan wrote:
>Changed committed to cay150 and HEAD.
>
> > -----Original Message-----
> > From: Greg Wright [mailto:gwright@real.com]
> > Sent: Thursday, March 09, 2006 4:29 PM
> > To: Todd Zupan
> > Cc: video-dev@helixcommunity.org
> > Subject: Re: [Video-dev] CR: bug 159898, assertion during video playback
> >
> > Todd Zupan wrote:
> > > Yes, since it sets the values during WinDraw2_Open.  That is called
> > whenever
> > > the site switches to a new monitor, so the new values will be properly
> > > retrieved.
> > >
> > > I just realized that it doesn't account for a DC being passed, though.
> > I
> > > never encountered this to be the case, but I assume the paramater is
> > there
> > > for that sole purpose.  I will submit a corrected CR in a moment.
> > > Basically, it will only call WinDraw_GetDeviceCaps when no DC was passed
> > > (which is the case for primary blitting).
> >
> > Go ahead and send out the new CR, but also go ahead and check it
> > in. I am sure it is fine. If I see anything after the fact I will
> > bring it up.
> >
> > --greg.
> >
> > >
> > > Todd Zupan
> > >
> > >> -----Original Message-----
> > >> From: Greg Wright [mailto:gwright@real.com]
> > >> Sent: Thursday, March 09, 2006 4:16 PM
> > >> To: Todd Zupan
> > >> Cc: video-dev@helixcommunity.org
> > >> Subject: Re: [Video-dev] CR: bug 159898, assertion during video
> > playback
> > >>
> > >> This looks good.
> > >>
> > >> does it work with multi-monitor setups?
> > >>
> > >> --greg.
> > >>
> > >>
> > >> Todd Zupan wrote:
> > >>> Modified by: tzupan@real.com
> > >>>
> > >>> Date: 3/9/2006
> > >>>
> > >>> Project: helix
> > >>>
> > >>>
> > >>>
> > >>> Synopsis: Player was throwing an assertion during playback due to a 0
> > >> bit
> > >>> depth being returned.
> > >>>
> > >>>
> > >>>
> > >>> Overview: During playback, the player would throw an assertion that it
> > >>> couldn't determine the bit depth of the display.  This is because
> > >>> CHXWinSite::_GetDeviceCaps was returning 0 for the bit depth of the
> > >> display
> > >>> properties.  The fix is to retrieve the values for bit depth, h-res,
> > and
> > >>> v-res, during the initialization of WinDraw.  WinDraw will hold these
> > >>> values, and a new function, WinDraw_GetDeviceCaps, will be used to
> > >> return
> > >>> them.  Since these values are constant, we only need to check them
> > once;
> > >>> then CHXWinSite::_GetDeviceCaps can just call WinDraw_GetDeviceCaps
> > and
> > >> get
> > >>> the proper values directly.
> > >>>
> > >>>
> > >>>
> > >>> Files Modified:
> > >>>
> > >>> platform/win/windraw2.cpp
> > >>>
> > >>> platform/win/winsite.cpp
> > >>>
> > >>> pub/platform/win/windraw2.h
> > >>>
> > >>>
> > >>>
> > >>> Image Size and Heap Use Impact:
> > >>>
> > >>> little to none
> > >>>
> > >>>
> > >>>
> > >>> Platforms and Profiles Affected:
> > >>>
> > >>>       Win32
> > >>>
> > >>>
> > >>>
> > >>> Platforms and Profiles Build Verified:
> > >>>
> > >>>       Win32
> > >>>
> > >>>
> > >>>
> > >>> Platforms and Profiles Functionality verified:
> > >>>
> > >>>       Win32
> > >>>
> > >>>
> > >>>
> > >>> Branch:
> > >>>
> > >>>       Cay150, HEAD
> > >>>
> > >>>
> > >>>
> > >>> Copyright Assignment:
> > >>>
> > >>> RealNetworks Contractor
> > >>>
> > >>>
> > >>>
> > >>>
> > >>> ----------------------------------------------------------------------
> > --
> > >>>
> > >>> _______________________________________________
> > >>> Video-dev mailing list
> > >>> Video-dev@helixcommunity.org
> > >>> http://lists.helixcommunity.org/mailman/listinfo/video-dev
> > >
> > >
> > > _______________________________________________
> > > Video-dev mailing list
> > > Video-dev@helixcommunity.org
> > > http://lists.helixcommunity.org/mailman/listinfo/video-dev
> > >
>
>
>_______________________________________________
>Video-dev mailing list
>Video-dev@helixcommunity.org
>http://lists.helixcommunity.org/mailman/listinfo/video-dev

[prev in list] [next in list] [prev in thread] [next in thread] 