[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    Re: [Protocol-dev] CR: fix HTTPResponseMessage::asString with
From:       Eric Hyche <ehyche () real ! com>
Date:       2010-01-07 14:21:30
Message-ID: FAC5FB50-859D-4098-9FBC-8F64A7522BF7 () real ! com
[Download RAW message or body]

Looks good.

On Jan 6, 2010, at 4:01 PM, Jamie Gordon wrote:

> Synopsis
> ========
> Fixes an ancient bug in HTTPResponseMessage::asString
> Branches: HEAD (SERVER_CURRENT)
> Suggested Reviewer: dcollins, anyone
> 
> 
> Description
> ===========
> HTTPResponseMessage::asString was adding an extra CRLF *after* the
> content body instead of before! This has previously been used only
> for generated HTML error responses in certain cases, which had a
> bizarre work-around that mostly worked.
> 
> This fixes the bug and the work-around.
> 
> 
> Files Affected
> ==============
> protocol/http/httpmsg.cpp
> server/protocol/http/httpprot.cpp
> 
> Testing Performed
> =================
> Unit Tests:
> 
> Integration Tests:
> Verified 404 response is correct as expected, with correct CRLFs between
> headers and body, no extra CRLF after the body, and correct
> Content-Length, and is loaded and displayed properly in the browser.
> 
> Leak Tests:
> None
> 
> Performance Tests:
> None
> 
> Platforms Tested: win32-i386-vc7
> Build verified: win32-i386-vc7
> 
> 
> QA Hints
> ===============
> 
> n/a
> 
> 
> 
> 
> 
> 
> <http.diff><ATT00001..txt>

Eric Hyche (ehyche@real.com)
Principal Engineer
RealNetworks, Inc.



_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev

[prev in list] [next in list] [prev in thread] [next in thread]