[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    [Protocol-dev] Checkin: fix HTTPResponseMessage::asString with
From:       Jamie Gordon <jgordon () real ! com>
Date:       2010-01-06 23:07:39
Message-ID: 4B4517BB.9050602 () real ! com
[Download RAW message or body]

Synopsis
========
Fixes an ancient bug in HTTPResponseMessage::asString
Branches: HEAD (SERVER_CURRENT)
Reviewer: chytanya


Description
===========
HTTPResponseMessage::asString was adding an extra CRLF *after* the
content body instead of before! This has previously been used only
for generated HTML error responses in certain cases, which had a
bizarre work-around that mostly worked.

This fixes the bug and the work-around.


Files Affected
==============
protocol/http/httpmsg.cpp
server/protocol/http/httpprot.cpp


Testing Performed
=================
Unit Tests:

Integration Tests:
Verified 404 response is correct as expected, with correct CRLFs between
headers and body, no extra CRLF after the body, and correct
Content-Length, and is loaded and displayed properly in the browser.

Leak Tests:
None

Performance Tests:
None

Platforms Tested: win32-i386-vc7
Build verified: win32-i386-vc7


QA Hints
===============

n/a








_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev
[prev in list] [next in list] [prev in thread] [next in thread]