[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    [Protocol-dev] RE: [Nokia-private-dev] CR: AHAN-7FKDLJ
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2008-10-15 17:22:36
Message-ID: 00ab01c92eea$9f42cd30$ddc86790$ () com
[Download RAW message or body]

Looks good.

=======================================
Eric Hyche (ehyche@real.com)
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: nokia-private-dev-bounces@helixcommunity.org [mailto:nokia-private-dev-
>bounces@helixcommunity.org] On Behalf Of ext-jesus.1.rodriguez@nokia.com
>Sent: Wednesday, October 15, 2008 11:29 AM
>To: protocol-dev@helixcommunity.org
>Cc: nokia-private-dev@helixcommunity.org
>Subject: [Nokia-private-dev] CR: AHAN-7FKDLJ Vulnerabilities in RTSP
>
>"Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks, and
>I am authorized to contribute this code under said agreement."
>
>Modified by: ext-jesus.1.rodriguez@nokia.com
>Date: 10/15/2008
>Project: symbianMmf_rel
>Bug Number: AHAN-7FKDLJ
>
>Synopsis: Helix crashes when getting a long RTSP error code
>
>Overview:
>Crash occuring in SafeSprintf() when, during an RTSP conversation, the client receives a long error
>code.
>
>Fix:
>When allocating memory to format the debug string, take in account the length of the error code,
>within RTSPResponseMessage::asString().
>
>Files Added: none
>
>Files Modified:
>/protocol/rtsp/rtspmsg.cpp
>
>--- rtsp/rtspmsg.cpp 2 Aug 2005 18:00:42 -0000 1.9
>+++ rtsp/rtspmsg.cpp 10 Oct 2008 15:51:25 -0000
>@@ -590,7 +590,7 @@
> CHXString
> RTSPResponseMessage::asString()
> {
>- int lenTmpBuf = (int)(m_errorMsg.GetLength() + 80);
>+ int lenTmpBuf = (int)(m_errorMsg.GetLength() + m_errorCode.GetLength()
>+ + 80);
>     char* pTmpBuf = new char[lenTmpBuf];
>     SafeSprintf(pTmpBuf, (UINT32)lenTmpBuf, "RTSP/%d.%d %s %s\r\n",
>  majorVersion(), minorVersion(), (const char*)m_errorCode,
>
>Image Size and Heap Use impact: Negligible Module Release testing (STIF, Audio): Passed Test case(s)
>Added: No Memory leak check performed: Passed, no leaks found.
>
>Platforms and Profiles Build Verified:
>helix-client-s60-32-mmf-mdf-arm
>helix-client-s60-50-mmf-mdf-arm
>
>Platforms and Profiles Functionality verified: armv5, winscw
>
>Branch: 210Cayennes, 221Cayennes, Head
>
>Cheers,
>JA


_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev
[prev in list] [next in list] [prev in thread] [next in thread]