[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-dev
Subject:    [Filesystem-dev] CR/checkin: build-buster in filesystem/http on HEAD
From:       Jamie Gordon <jgordon () real ! com>
Date:       2009-10-12 20:44:00
Message-ID: 4AD39510.2080006 () real ! com
[Download RAW message or body]

Synopsis
========
Fix build buster
Branches: HEAD (SERVER_CURRENT)
Suggested Reviewer: anyone


Description
===========
Fixes build buster in filesystem/http

Files Affected
==============
filsystem/http/httpfsys.cpp


Testing Performed
=================

Build verified: linux-rhel5-i686



cvs diff: Diffing .
Index: httpfsys.cpp
===================================================================
RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
retrieving revision 1.136
diff -u -w -r1.136 httpfsys.cpp
--- httpfsys.cpp        9 Oct 2009 15:27:03 -0000       1.136
+++ httpfsys.cpp        12 Oct 2009 19:27:56 -0000
@@ -236,8 +236,11 @@
  // sense of the response and associated headers
  #define HTTP_MIN_STARTUP_LENGTH_NEEDED              5       // bytes
  #define HTTP_NONSTANDARD_MIN_STARTUP_LENGTH_NEEDED  1024    // bytes
+
  #if defined _SYMBIAN
  #define DFLT_BUFFER_AHEAD_AMOUNT                       0x00002000 
// 8K
+#else
+#define DFLT_BUFFER_AHEAD_AMOUNT                    0
  #endif

  #define ICECAST_META_SIZE_MULTIPLE                  16      // bytes



On 10/12/2009 1:29 PM, Jamie Gordon wrote:
> I'm going to guess it should be 0 for non-symbian builds, as that is
> what it was initialized to before this change and the usage doesn't
> appear to have been changed.
> 
> I don't see any CR or checkin mails for this change on any relevant
> mailing lists, has this been reviewed?
> 
> Jamie
> 
> On 10/12/2009 11:23 AM, Dean Collins wrote:
>> With regards to the following check-in:
>>
>> http://lists.helixcommunity.org/pipermail/filesystem-cvs/2009-October/000833.html 
>>
>>
>>
>> Note that DFLT_BUFFER_AHEAD_AMOUNT is only defined for _SYMBIAN builds:
>>
>> +#if defined _SYMBIAN
>> +#define DFLT_BUFFER_AHEAD_AMOUNT                       0x00002000     
>> // 8K
>> +#endif
>>
>>
>> Later, the define is referenced when assigning the default value
>> for m_ulBufferAheadAmount:
>>
>> +    , m_ulBufferAheadAmount(DFLT_BUFFER_AHEAD_AMOUNT)
>>
>>
>> This causes a build-buster on all non-Symbian builds.
>>
>>
>> What should this be set to for non-Symbian builds?
>>
>> Dean
>>
> 
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev

_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
[prev in list] [next in list] [prev in thread] [next in thread]