[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-dev
Subject:    [Filesystem-dev] Re: build-buster in filesystem/http on HEAD
From:       Jamie Gordon <jgordon () real ! com>
Date:       2009-10-12 20:29:10
Message-ID: 4AD39196.1030709 () real ! com
[Download RAW message or body]

I'm going to guess it should be 0 for non-symbian builds, as that is
what it was initialized to before this change and the usage doesn't
appear to have been changed.

I don't see any CR or checkin mails for this change on any relevant
mailing lists, has this been reviewed?

Jamie

On 10/12/2009 11:23 AM, Dean Collins wrote:
> With regards to the following check-in:
> 
> http://lists.helixcommunity.org/pipermail/filesystem-cvs/2009-October/000833.html
> 
> 
> Note that DFLT_BUFFER_AHEAD_AMOUNT is only defined for _SYMBIAN builds:
> 
> +#if defined _SYMBIAN
> +#define DFLT_BUFFER_AHEAD_AMOUNT                       0x00002000     // 8K
> +#endif
> 
> 
> Later, the define is referenced when assigning the default value
> for m_ulBufferAheadAmount:
> 
> +    , m_ulBufferAheadAmount(DFLT_BUFFER_AHEAD_AMOUNT)
> 
> 
> This causes a build-buster on all non-Symbian builds.
> 
> 
> What should this be set to for non-Symbian builds?
> 
> Dean
> 

_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
[prev in list] [next in list] [prev in thread] [next in thread]