[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-dev
Subject: [datatype-dev] CR: EMVK-7ZHK6H : Frame rate and MCU load during
From: <ext-ram.mukunda () nokia ! com>
Date: 2010-01-26 8:08:35
Message-ID: E839BB5467CE1640B3CC2F90F647A52C274E5B5B37 () NOK-EUMSG-02 ! mgdnok ! nokia ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
"Nokia submits this code under the terms of a commercial contribution agree=
ment with RealNetworks, and I am authorized to contribute this code under s=
aid agreement"
Modified By: ext-anugrah.2.kashari@nokia.com<mailto:ext-anugrah.2.kashari@n=
okia.com>
Review By: yury.ramanovich@nokia.com
Error-ID: EMVK-7ZHK6H
Date : 26/01/2010
Project: SymbianMmf_wm
Synopsis: Frame rate and MCU load during H.264 720p 30fps with multichanne=
l audio local Video Playb
Overview : CMMFDevVideoPlay:: ConfigureDecoderL() leaves with error code K=
ErrCorrupt (-20). In CMDFDevVideoClient this is converted to HXR_CORRUPT_FI=
LE, but in CMdfVideoAdapter it is again converted to the generic HXR_FAIL. =
HXMMFCtrlImp converts HXR_FAIL to KErrGeneral(-2) therefore UI displays wro=
ng message to user.
Fix: We have kept current error mapping intact and added check for KErrCor=
rupt.
Files modified & changes 210Cays , Brizo420 and Head :
/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp
Image Size and Heap Use impact: No major impact
Module Release testing (STIF) : NA
Test case(s) Added : No
Memory leak check performed : Passed, No additional leaks introduced.
Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5
Branch : 210Cays, Brizo420 & Head :
CVS Diff: attached.
[Attachment #5 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40">
<head>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Verdana;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoPlainText, li.MsoPlainText, div.MsoPlainText
{mso-style-priority:99;
mso-style-link:"Plain Text Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.5pt;
font-family:Consolas;}
span.PlainTextChar
{mso-style-name:"Plain Text Char";
mso-style-priority:99;
mso-style-link:"Plain Text";
font-family:Consolas;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Verdana","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoPlainText>"Nokia submits this code under the terms of a
commercial contribution agreement with RealNetworks, and I am authorized to
contribute this code under said agreement”<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Modified By: <a
href="mailto:ext-anugrah.2.kashari@nokia.com">ext-anugrah.2.kashari@nokia.com</a><o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Review By: yury.ramanovich@nokia.com<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Error-ID: EMVK-7ZHK6H<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Date : 26/01/2010<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Project: SymbianMmf_wm<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Synopsis: Frame rate and MCU load during H.264 720p
30fps with multichannel audio local Video Playb<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Overview : CMMFDevVideoPlay:: ConfigureDecoderL()
leaves with error code KErrCorrupt (-20). In CMDFDevVideoClient this is
converted to HXR_CORRUPT_FILE, but in CMdfVideoAdapter it is again converted to
the generic HXR_FAIL. HXMMFCtrlImp converts HXR_FAIL to KErrGeneral(-2)
therefore UI displays wrong message to user. <o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Fix: We have kept current error mapping intact and
added check for KErrCorrupt. <o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Files modified & changes 210Cays , Brizo420 and Head
> <o:p></o:p></p>
<p class=MsoPlainText>/cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp &n \
bsp;
<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Image Size and Heap Use impact: No major impact <o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Module Release testing (STIF) : NA<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Test case(s) Added : No<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Memory leak check performed : Passed, No additional leaks
introduced.<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Platforms and Profiles Build Verified:
helix-client-s60-52-mmf-mdf-dsp & \
nbsp; &nb \
sp;   \
; & \
nbsp;
<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Platforms and Profiles Functionality verified: \
armv5<o:p></o:p></p>
<p class=MsoPlainText><o:p> </o:p></p>
<p class=MsoPlainText>Branch : 210Cays, Brizo420 & Head :<o:p></o:p></p>
<p class=MsoPlainText> <o:p></o:p></p>
<p class=MsoPlainText>CVS Diff: attached.<o:p></o:p></p>
</div>
</body>
</html>
["datatype_diff.txt" (text/plain)]
Index: mdfvideoadapter.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.3.2.104
diff -u -w -r1.3.2.104 mdfvideoadapter.cpp
--- mdfvideoadapter.cpp 19 Jan 2010 19:18:31 -0000 1.3.2.104
+++ mdfvideoadapter.cpp 25 Jan 2010 10:08:38 -0000
@@ -410,6 +410,10 @@
{
retVal = HXR_UNSUPPORTED_VIDEO;
}
+ else if(error == KErrCorrupt || retVal == HXR_CORRUPT_FILE)
+ {
+ retVal = HXR_CORRUPT_FILE;
+ }
else
{
retVal = HXR_FAIL;
_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic