[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-dev
Subject: [datatype-dev] CR: OULM-7Z6EUR - Phone crashes while playing a MP4
From: <ext-shashi.merapala () nokia ! com>
Date: 2010-01-26 6:54:27
Message-ID: EEF08FFE3AB06D43A1F6BDF1C0F779B31F1799A1EA () NOK-EUMSG-02 ! mgdnok ! nokia ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
"Nokia submits this code under the terms of a commercial contribution agree=
ment with RealNetworks, and I am authorized to contribute this code under s=
aid agreement."
Modified by: ext-shashi.merapala@nokia.com<mailto:ext-shashi.merapala@noki=
a.com>
Reviewed by: patrick.amick@nokia.com<mailto:patrick.amick@nokia.com>
Date: 01/26/2010
Project: SymbianMmf_wm
Error Id: OULM-7Z6EUR
Synopsis: Helix Phone crashes while playing a MP4 file from SD card with e=
rror:MMFcontrollerProxyserver-246
Overview: Error reported mp4 file does not comply with mp4 standards. In E=
SDS Box, it does not contain DeSpecificTag(0x05), due to which helix crashe=
s. Correction has been made to discard the non-compliant media content and =
play the file partially.
Solution: Diffs attached
Files added: None
Files modified: \datatype\mp4\payload\mp4apyld.cpp
\datatype\mp4\payload\mp4vpyld.cpp
Image size and heap use impact: None
Module release testing (STIF): Passed
Test case(s) added: No
Memory leak check performed: Yes. No new leaks introduced
Platforms and profiles build verified: helix-client-s60-52-mmf-mdf-dsp
Platforms and profiles functionality verified: armv5, winscw
Branch: 210CayS, HEAD, 420Brizo
[Attachment #5 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page Section1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.Section1
{page:Section1;}
-->
</style>
<!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang=EN-US link=blue vlink=purple>
<div class=Section1>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>"Nokia submits this code under the terms of a
commercial contribution agreement with RealNetworks, and I am authorized to
contribute this code under said agreement."<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Modified by: </span><span style='font-size:
10.0pt;font-family:"Times New Roman","serif"'><a
href="mailto:ext-shashi.merapala@nokia.com">ext-shashi.merapala@nokia.com</a></span><span
style='font-size:10.0pt;font-family:"Courier New"'><o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Reviewed by: </span><span style='font-size:
10.0pt;font-family:"Times New Roman","serif"'><a
href="mailto:patrick.amick@nokia.com">patrick.amick@nokia.com</a></span><span
style='font-size:10.0pt;font-family:"Courier New"'><o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Date: 01/26/2010<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Project: SymbianMmf_wm<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Error Id: OULM-7Z6EUR <o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Synopsis: Helix</span> <span style='font-size:
10.0pt;font-family:"Courier New"'>Phone crashes while playing a MP4 file from
SD card with error:MMFcontrollerProxyserver-246<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Overview: Error reported mp4 file does not
comply with mp4 standards. In ESDS Box, it does not contain
DeSpecificTag(0x05), due to which helix crashes. Correction has been made to
discard the non-compliant media content and play the file \
partially.<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier \
New"'> \
<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Solution: Diffs attached<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'> <o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Files added: None<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New"'>Files
modified: \datatype\mp4\payload\mp4apyld.cpp <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier \
New"'>
\datatype\mp4\payload\mp4vpyld.cpp
<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier \
New"'> \
<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Image size and heap use impact: \
None<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Module release testing (STIF): \
Passed<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Test case(s) added: No<o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'>Memory leak check performed: Yes. No new leaks
introduced <o:p></o:p></span></p>
<p class=MsoNormal style='text-autospace:none'><span style='font-size:10.0pt;
font-family:"Courier New"'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New"'>Platforms
and profiles build verified: \
helix-client-s60-52-mmf-mdf-dsp<o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier \
New"'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New"'>Platforms
and profiles functionality verified: armv5, winscw <o:p></o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier \
New"'><o:p> </o:p></span></p>
<p class=MsoNormal><span style='font-size:10.0pt;font-family:"Courier New"'>Branch:
210CayS, HEAD, 420Brizo<o:p></o:p></span></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
<p class=MsoNormal><o:p> </o:p></p>
</div>
</body>
</html>
["datatype_diff.txt" (text/plain)]
Index: mp4/payload/mp4apyld.cpp
===================================================================
RCS file: /cvsroot/datatype/mp4/payload/mp4apyld.cpp,v
retrieving revision 1.14.6.4
diff -u -w -r1.14.6.4 mp4apyld.cpp
--- mp4/payload/mp4apyld.cpp 13 Nov 2009 19:33:44 -0000 1.14.6.4
+++ mp4/payload/mp4apyld.cpp 22 Jan 2010 12:47:57 -0000
@@ -429,11 +429,14 @@
if (pDCDesc)
{
pDSIDesc = pDCDesc->m_pDecSpecificInfo;
+ if(pDSIDesc)
+ {
retVal = HXR_OK;
}
}
+ }
- if (SUCCEEDED(retVal) && pDSIDesc)
+ if (SUCCEEDED(retVal))
{
m_ulAudioConfigSize = pDSIDesc->m_ulLength;
Index: mp4/payload/mp4vpyld.cpp
===================================================================
RCS file: /cvsroot/datatype/mp4/payload/mp4vpyld.cpp,v
retrieving revision 1.18.2.4
diff -u -w -r1.18.2.4 mp4vpyld.cpp
--- mp4/payload/mp4vpyld.cpp 6 Nov 2009 20:00:24 -0000 1.18.2.4
+++ mp4/payload/mp4vpyld.cpp 22 Jan 2010 12:47:57 -0000
@@ -476,11 +476,14 @@
if (pDCDesc)
{
pDSIDesc = pDCDesc->m_pDecSpecificInfo;
+ if(pDSIDesc)
+ {
retVal = HXR_OK;
}
}
+ }
- if (SUCCEEDED(retVal) && pDSIDesc)
+ if (SUCCEEDED(retVal))
{
m_ulBitstreamHeaderSize = pDSIDesc->m_ulLength;
_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic