[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 129922: Adding Fit to width
From: Aurélien Gâteau <agateau () kde ! org>
Date: 2017-03-05 19:25:41
Message-ID: 20170305192541.27981.53477 () mimi ! kde ! org
[Download RAW message or body]
--===============7155591451598093100==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129922/#review102725
-----------------------------------------------------------
I finally found the time to review your work. There is one annoying issue to fix \
before it can go in:
- enable the "Keep same zoom and position" option in the config dialog
- click on "Fit to width"
- open image A
- switch to image B, which does not require the same zoom to fit width => the zoom is \
not updated
- Aurélien Gâteau
On Feb. 28, 2017, 8:18 p.m., Eldin Gagulić wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129922/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2017, 8:18 p.m.)
>
>
> Review request for Gwenview.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> Hi,
>
> I found it useful to have Fit to Width option for things I use gwenview for, so I \
> added it. It's allmost completely copied code from Fit option, with few exceptions. \
> If you think it will be useful add it.
> P.S. I never contribute for KDE before.
>
>
> Diffs
> -----
>
> lib/documentview/abstractdocumentviewadapter.h 4fc9b135
> lib/documentview/abstractimageview.h f7dd32ea
> lib/documentview/abstractimageview.cpp f01b341d
> lib/documentview/documentview.h b9f436e0
> lib/documentview/documentview.cpp 28415d3b
> lib/documentview/documentviewcontroller.h 26e8f9c6
> lib/documentview/documentviewcontroller.cpp 40e29cbc
> lib/documentview/documentviewsynchronizer.h 0a7c9da2
> lib/documentview/documentviewsynchronizer.cpp 89b0b61f
> lib/documentview/rasterimageview.cpp 5c4f5514
> lib/documentview/rasterimageviewadapter.h b6221271
> lib/documentview/rasterimageviewadapter.cpp af9bbd46
> lib/documentview/svgviewadapter.h eae9a03a
> lib/documentview/svgviewadapter.cpp 5069b777
> lib/zoomwidget.h d5de70b9
> lib/zoomwidget.cpp cae63b6e
>
> Diff: https://git.reviewboard.kde.org/r/129922/diff/
>
>
> Testing
> -------
>
> Compiles, runs. Tested with couple of raster and svg images.
>
>
> File Attachments
> ----------------
>
> 0001-Add-Fit-to-width.patch
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/28/54f7ef44-9866-4daf-85e8-3560a0accdc2__0001-Add-Fit-to-width.patch
> 0002-Add-Fit-to-width-2.patch
> https://git.reviewboard.kde.org/media/uploaded/files/2017/02/28/c05b4935-525d-4bf7-aea4-0f6967358a25__0002-Add-Fit-to-width-2.patch
>
>
> Thanks,
>
> Eldin Gagulić
>
>
--===============7155591451598093100==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129922/">https://git.reviewboard.kde.org/r/129922/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I \
finally found the time to review your work. There is one annoying issue to fix before \
it can go in:</p> <ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 \
1em;line-height: inherit;white-space: normal;"> <li style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: normal;">enable the "Keep same \
zoom and position" option in the config dialog</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">click \
on "Fit to width"</li> <li style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: normal;">open image A</li> <li style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">switch \
to image B, which does not require the same zoom to fit width => the zoom is not \
updated</li> </ul></pre>
<br />
<p>- Aurélien Gâteau</p>
<br />
<p>On February 28th, 2017, 8:18 p.m. CET, Eldin Gagulić wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Gwenview.</div>
<div>By Eldin Gagulić.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2017, 8:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Hi,</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">I found it useful to \
have Fit to Width option for things I use gwenview for, so I added it. It's allmost \
completely copied code from Fit option, with few exceptions. If you think it will be \
useful add it.</p> <p style="padding: 0;text-rendering: inherit;margin: \
0;line-height: inherit;white-space: inherit;">P.S. I never contribute for KDE \
before.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Compiles, runs. Tested with couple of raster and svg \
images.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/documentview/abstractdocumentviewadapter.h <span style="color: \
grey">(4fc9b135)</span></li>
<li>lib/documentview/abstractimageview.h <span style="color: \
grey">(f7dd32ea)</span></li>
<li>lib/documentview/abstractimageview.cpp <span style="color: \
grey">(f01b341d)</span></li>
<li>lib/documentview/documentview.h <span style="color: grey">(b9f436e0)</span></li>
<li>lib/documentview/documentview.cpp <span style="color: \
grey">(28415d3b)</span></li>
<li>lib/documentview/documentviewcontroller.h <span style="color: \
grey">(26e8f9c6)</span></li>
<li>lib/documentview/documentviewcontroller.cpp <span style="color: \
grey">(40e29cbc)</span></li>
<li>lib/documentview/documentviewsynchronizer.h <span style="color: \
grey">(0a7c9da2)</span></li>
<li>lib/documentview/documentviewsynchronizer.cpp <span style="color: \
grey">(89b0b61f)</span></li>
<li>lib/documentview/rasterimageview.cpp <span style="color: \
grey">(5c4f5514)</span></li>
<li>lib/documentview/rasterimageviewadapter.h <span style="color: \
grey">(b6221271)</span></li>
<li>lib/documentview/rasterimageviewadapter.cpp <span style="color: \
grey">(af9bbd46)</span></li>
<li>lib/documentview/svgviewadapter.h <span style="color: \
grey">(eae9a03a)</span></li>
<li>lib/documentview/svgviewadapter.cpp <span style="color: \
grey">(5069b777)</span></li>
<li>lib/zoomwidget.h <span style="color: grey">(d5de70b9)</span></li>
<li>lib/zoomwidget.cpp <span style="color: grey">(cae63b6e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129922/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/02/28/54f7ef44 \
-9866-4daf-85e8-3560a0accdc2__0001-Add-Fit-to-width.patch">0001-Add-Fit-to-width.patch</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2017/02/28/c05b4935 \
-525d-4bf7-aea4-0f6967358a25__0002-Add-Fit-to-width-2.patch">0002-Add-Fit-to-width-2.patch</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============7155591451598093100==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic