From gwenview-devel Sun Mar 05 19:25:41 2017 From: =?utf-8?b?QXVyw6lsaWVuIEfDonRlYXU=?= Date: Sun, 05 Mar 2017 19:25:41 +0000 To: gwenview-devel Subject: Re: Review Request 129922: Adding Fit to width Message-Id: <20170305192541.27981.53477 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=gwenview-devel&m=148874194600601 --===============7155591451598093100== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129922/#review102725 ----------------------------------------------------------- I finally found the time to review your work. There is one annoying issue to fix before it can go in: - enable the "Keep same zoom and position" option in the config dialog - click on "Fit to width" - open image A - switch to image B, which does not require the same zoom to fit width => the zoom is not updated - Aurélien Gâteau On Feb. 28, 2017, 8:18 p.m., Eldin Gagulić wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129922/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 8:18 p.m.) > > > Review request for Gwenview. > > > Repository: gwenview > > > Description > ------- > > Hi, > > I found it useful to have Fit to Width option for things I use gwenview for, so I added it. > It's allmost completely copied code from Fit option, with few exceptions. If you think it will be useful add it. > > P.S. I never contribute for KDE before. > > > Diffs > ----- > > lib/documentview/abstractdocumentviewadapter.h 4fc9b135 > lib/documentview/abstractimageview.h f7dd32ea > lib/documentview/abstractimageview.cpp f01b341d > lib/documentview/documentview.h b9f436e0 > lib/documentview/documentview.cpp 28415d3b > lib/documentview/documentviewcontroller.h 26e8f9c6 > lib/documentview/documentviewcontroller.cpp 40e29cbc > lib/documentview/documentviewsynchronizer.h 0a7c9da2 > lib/documentview/documentviewsynchronizer.cpp 89b0b61f > lib/documentview/rasterimageview.cpp 5c4f5514 > lib/documentview/rasterimageviewadapter.h b6221271 > lib/documentview/rasterimageviewadapter.cpp af9bbd46 > lib/documentview/svgviewadapter.h eae9a03a > lib/documentview/svgviewadapter.cpp 5069b777 > lib/zoomwidget.h d5de70b9 > lib/zoomwidget.cpp cae63b6e > > Diff: https://git.reviewboard.kde.org/r/129922/diff/ > > > Testing > ------- > > Compiles, runs. Tested with couple of raster and svg images. > > > File Attachments > ---------------- > > 0001-Add-Fit-to-width.patch > https://git.reviewboard.kde.org/media/uploaded/files/2017/02/28/54f7ef44-9866-4daf-85e8-3560a0accdc2__0001-Add-Fit-to-width.patch > 0002-Add-Fit-to-width-2.patch > https://git.reviewboard.kde.org/media/uploaded/files/2017/02/28/c05b4935-525d-4bf7-aea4-0f6967358a25__0002-Add-Fit-to-width-2.patch > > > Thanks, > > Eldin Gagulić > > --===============7155591451598093100== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129922/ 

I finally found the time to review your work. There is one annoying issue to fix before it can go in:


    

  • enable the "Keep same zoom and position" option in the config dialog
    • 

  • click on "Fit to width"
    • 

  • open image A
    • 

  • switch to image B, which does not require the same zoom to fit width => the zoom is not updated
    •

- Aurélien Gâteau


On February 28th, 2017, 8:18 p.m. CET, Eldin Gagulić wrote:

Review request for Gwenview.
By Eldin Gagulić.

Updated Feb. 28, 2017, 8:18 p.m.

Repository: gwenview

Description 

Hi,


I found it useful to have Fit to Width option for things I use gwenview for, so I added it.
It's allmost completely copied code from Fit option, with few exceptions. If you think it will be useful add it.


P.S. I never contribute for KDE before.

Testing 

Compiles, runs. Tested with couple of raster and svg images.

Diffs

  • lib/documentview/abstractdocumentviewadapter.h (4fc9b135)
  • lib/documentview/abstractimageview.h (f7dd32ea)
  • lib/documentview/abstractimageview.cpp (f01b341d)
  • lib/documentview/documentview.h (b9f436e0)
  • lib/documentview/documentview.cpp (28415d3b)
  • lib/documentview/documentviewcontroller.h (26e8f9c6)
  • lib/documentview/documentviewcontroller.cpp (40e29cbc)
  • lib/documentview/documentviewsynchronizer.h (0a7c9da2)
  • lib/documentview/documentviewsynchronizer.cpp (89b0b61f)
  • lib/documentview/rasterimageview.cpp (5c4f5514)
  • lib/documentview/rasterimageviewadapter.h (b6221271)
  • lib/documentview/rasterimageviewadapter.cpp (af9bbd46)
  • lib/documentview/svgviewadapter.h (eae9a03a)
  • lib/documentview/svgviewadapter.cpp (5069b777)
  • lib/zoomwidget.h (d5de70b9)
  • lib/zoomwidget.cpp (cae63b6e)

View Diff

File Attachments

  • 0001-Add-Fit-to-width.patch
  • 0002-Add-Fit-to-width-2.patch
    		•
    --===============7155591451598093100==--