'Re: Review Request 126437: Convert Profile away from the deprecated KSharedPtr'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 126437: Convert Profile away from the deprecated KSharedPtr
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2016-01-06 22:19:02
Message-ID: 20160106221902.6499.68756 () mimi ! kde ! org
[Download RAW message or body]

--===============2519893672730265584==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126437/#review90717
-----------------------------------------------------------

Ship it!

Ship It!

- Aurélien Gâteau

On déc. 20, 2015, 9:33 après-midi, Shlomi Fish wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126437/
> -----------------------------------------------------------
> 
> (Updated déc. 20, 2015, 9:33 après-midi)
> 
> 
> Review request for Gwenview.
> 
> 
> Repository: gwenview
> 
> 
> Description
> -------
> 
> This converts Profile away from KSharedPtr which is deprecated in KF5. It \
> eliminates some warnings. There is another instance of KSharedPtr in gwenview which \
> I have had more difficulty converting. 
> 
> Diffs
> -----
> 
> lib/cms/cmsprofile.h 17cee19 
> tests/auto/cmsprofiletest.cpp f59c931 
> 
> Diff: https://git.reviewboard.kde.org/r/126437/diff/
> 
> 
> Testing
> -------
> 
> I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in \
> gwenview in the process but it seems to be in  the gwenview from Mageia as well.
> 
> 
> Thanks,
> 
> Shlomi Fish
> 
> 

--===============2519893672730265584==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126437/">https://git.reviewboard.kde.org/r/126437/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>  <br />

<p>- Aurélien Gâteau</p>

<br />
<p>On décembre 20th, 2015, 9:33 après-midi CET, Shlomi Fish wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By Shlomi Fish.</div>

<p style="color: grey;"><i>Updated déc. 20, 2015, 9:33 après-midi</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This converts Profile away from KSharedPtr which is \
deprecated in KF5. It eliminates some warnings. There is another instance of \
KSharedPtr in gwenview which I have had more difficulty converting.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ran ./app/gwenview and everything mostly seems fine. \
I discovered a small bug in gwenview in the process but it seems to be in  the \
gwenview from Mageia as well.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/cms/cmsprofile.h <span style="color: grey">(17cee19)</span></li>

 <li>tests/auto/cmsprofiletest.cpp <span style="color: grey">(f59c931)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126437/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2519893672730265584==--

[Attachment #3 (text/plain)]

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 