From gwenview-devel Wed Jan 06 22:19:02 2016 From: =?utf-8?b?QXVyw6lsaWVuIEfDonRlYXU=?= Date: Wed, 06 Jan 2016 22:19:02 +0000 To: gwenview-devel Subject: Re: Review Request 126437: Convert Profile away from the deprecated KSharedPtr Message-Id: <20160106221902.6499.68756 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=gwenview-devel&m=145211875609485 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============9163378688042296484==" --===============9163378688042296484== Content-Type: multipart/alternative; boundary="===============2519893672730265584==" --===============2519893672730265584== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126437/#review90717 ----------------------------------------------------------- Ship it! Ship It! - Aurélien Gâteau On déc. 20, 2015, 9:33 après-midi, Shlomi Fish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126437/ > ----------------------------------------------------------- > > (Updated déc. 20, 2015, 9:33 après-midi) > > > Review request for Gwenview. > > > Repository: gwenview > > > Description > ------- > > This converts Profile away from KSharedPtr which is deprecated in KF5. It eliminates some warnings. There is another instance of KSharedPtr in gwenview which I have had more difficulty converting. > > > Diffs > ----- > > lib/cms/cmsprofile.h 17cee19 > tests/auto/cmsprofiletest.cpp f59c931 > > Diff: https://git.reviewboard.kde.org/r/126437/diff/ > > > Testing > ------- > > I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in gwenview in the process but it seems to be in > the gwenview from Mageia as well. > > > Thanks, > > Shlomi Fish > > --===============2519893672730265584== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126437/

Ship it!

Ship It!

- Aurélien Gâteau

On décembre 20th, 2015, 9:33 après-midi CET, Shlomi Fish wrote:

Review request for Gwenview.

By Shlomi Fish.

Updated déc. 20, 2015, 9:33 après-midi

Repository: gwenview

Description

This converts Profile away from KSharedPtr which is deprecated in KF5. It eliminates some warnings. There is another instance of KSharedPtr in gwenview which I have had more difficulty converting.

Testing

I ran ./app/gwenview and everything mostly seems fine. I discovered a small bug in gwenview in the process but it seems to be in the gwenview from Mageia as well.

Diffs

lib/cms/cmsprofile.h (17cee19)
tests/auto/cmsprofiletest.cpp (f59c931)

View Diff

--===============2519893672730265584==-- --===============9163378688042296484== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3dlbnZpZXct ZGV2ZWwgbWFpbGluZyBsaXN0Ckd3ZW52aWV3LWRldmVsQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtk ZS5vcmcvbWFpbG1hbi9saXN0aW5mby9nd2Vudmlldy1kZXZlbAo= --===============9163378688042296484==--