'Re: Review Request 124416: Do not scale up images smaller than the thumbnail size'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gwenview-devel
Subject:    Re: Review Request 124416: Do not scale up images smaller than the thumbnail size
From:       Aurélien Gâteau <agateau () kde ! org>
Date:       2015-11-05 13:40:39
Message-ID: 20151105134039.24343.34063 () mimi ! kde ! org
[Download RAW message or body]

--===============2843924307004620108==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124416/
-----------------------------------------------------------

(Updated Nov. 5, 2015, 1:40 p.m.)

Status
------

This change has been marked as submitted.

Review request for Gwenview.

Changes
-------

Submitted with commit 9cd7aa54e6d702c6e1d20d8554b0924f70c234fe by David Edmundson on \
behalf of Aurélien Gâteau to branch Applications/15.08.

Repository: gwenview

Description
-------

When generating thumbnails Gwenview asks the QImageReader to scale at load time if \
possible. Seems like the PNG reader gains support for this recently, resulting in \
Gwenview asking the PNG reader to scale images at load, including small images like \
icons, which gets scaled up to fit the thumbnail square. This is not good since it \
produces blurry thumbnails.

This patch checks if the image is larger than the thumbnail square before asking the \
QImageReader to scale.

Diffs
-----

  lib/thumbnailprovider/thumbnailgenerator.cpp \
54875f5df89530edf3aacbd6c30cf893ce0eb405 

Diff: https://git.reviewboard.kde.org/r/124416/diff/

Testing
-------

Tested with small and large images.

Thanks,

Aurélien Gâteau

--===============2843924307004620108==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/124416/">https://git.reviewboard.kde.org/r/124416/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Gwenview.</div>
<div>By Aurélien Gâteau.</div>

<p style="color: grey;"><i>Updated Nov. 5, 2015, 1:40 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 9cd7aa54e6d702c6e1d20d8554b0924f70c234fe by David \
Edmundson on behalf of Aurélien Gâteau to branch Applications/15.08.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">When generating thumbnails Gwenview asks the \
QImageReader to scale at load time if possible. Seems like the PNG reader gains \
support for this recently, resulting in Gwenview asking the PNG reader to scale \
images at load, including small images like icons, which gets scaled up to fit the \
thumbnail square. This is not good since it produces blurry thumbnails.</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">This patch checks if the image is larger than the thumbnail square before \
asking the QImageReader to scale.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Tested with small and large images.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>lib/thumbnailprovider/thumbnailgenerator.cpp <span style="color: \
grey">(54875f5df89530edf3aacbd6c30cf893ce0eb405)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/124416/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2843924307004620108==--

[Attachment #3 (text/plain)]

_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel

[prev in list] [next in list] [prev in thread] [next in thread] 