--===============9060418586106772541== Content-Type: multipart/alternative; boundary="===============2843924307004620108==" --===============2843924307004620108== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124416/ ----------------------------------------------------------- (Updated Nov. 5, 2015, 1:40 p.m.) Status ------ This change has been marked as submitted. Review request for Gwenview. Changes ------- Submitted with commit 9cd7aa54e6d702c6e1d20d8554b0924f70c234fe by David Edmundson on behalf of Aurélien Gâteau to branch Applications/15.08. Repository: gwenview Description ------- When generating thumbnails Gwenview asks the QImageReader to scale at load time if possible. Seems like the PNG reader gains support for this recently, resulting in Gwenview asking the PNG reader to scale images at load, including small images like icons, which gets scaled up to fit the thumbnail square. This is not good since it produces blurry thumbnails. This patch checks if the image is larger than the thumbnail square before asking the QImageReader to scale. Diffs ----- lib/thumbnailprovider/thumbnailgenerator.cpp 54875f5df89530edf3aacbd6c30cf893ce0eb405 Diff: https://git.reviewboard.kde.org/r/124416/diff/ Testing ------- Tested with small and large images. Thanks, Aurélien Gâteau --===============2843924307004620108== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/124416/

This change has been marked as submitted.

Review request for Gwenview.
By Aurélien Gâteau.

Updated Nov. 5, 2015, 1:40 p.m.

Changes

Submitted with commit 9cd7aa54e6d702c6e1d20d8554b0924f70c234fe by David Edmundson on behalf of Aurélien Gâteau to branch Applications/15.08.
Repository: gwenview

Description 

When generating thumbnails Gwenview asks the QImageReader to scale at load time if possible. Seems like the PNG reader gains support for this recently, resulting in Gwenview asking the PNG reader to scale images at load, including small images like icons, which gets scaled up to fit the thumbnail square. This is not good since it produces blurry thumbnails.


This patch checks if the image is larger than the thumbnail square before asking the QImageReader to scale.

Testing 

Tested with small and large images.

Diffs

  • lib/thumbnailprovider/thumbnailgenerator.cpp (54875f5df89530edf3aacbd6c30cf893ce0eb405)

View Diff
--===============2843924307004620108==-- --===============9060418586106772541== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KR3dlbnZpZXct ZGV2ZWwgbWFpbGluZyBsaXN0Ckd3ZW52aWV3LWRldmVsQGtkZS5vcmcKaHR0cHM6Ly9tYWlsLmtk ZS5vcmcvbWFpbG1hbi9saXN0aW5mby9nd2Vudmlldy1kZXZlbAo= --===============9060418586106772541==--