[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 113397: RAW preview in gwenview
From: "Martin Kyral" <martin.kyral () gmail ! com>
Date: 2013-11-07 15:21:01
Message-ID: 20131107152101.1494.86690 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Nov. 5, 2013, 5:04 p.m., Aurélien Gâteau wrote:
> > lib/thumbnailprovider/thumbnailgenerator.cpp, line 128
> > <http://git.reviewboard.kde.org/r/113397/diff/6/?file=206503#file206503line128>
> >
> > It looks to me like the new code is never going to use the embedded thumbnail, \
> > this could have a bad impact on performance.
>
> Martin Kyral wrote:
> Yep, it seems so. However, using the embedded small thumbnail has some serious \
> drawbacks:
> 1) there's no particular function in libraw (nor kdcraw), fetching the small size \
> thumbnail (unpack_thumb() returns the large preview if present) 2) not every raw \
> file contains the small thumb 3) the thumbnail (if any) is always 160x120 (4:3) \
> while majority of the raw-enabled cameras shoot 3:2 pictures. That leads to ugly \
> black stripes along the longer sides of the thumbnail. 4) the thumbnail view shows \
> the 160x120 as a resolution of the image (not sure if this can be overriden by exif \
> data and how)
> I tested various formats with the following results:
>
> 1) canon cr2 loads nice big thumbnails even without any additional support in \
> gwenview/dolphin. It seems that it behaves as JPEG when loaded which is pretty the \
> same as loadEmbeddedPreview does. 2) nikon nef, pentax dnf, leica dng has ugly back \
> stripes on the longer sides, reported size 160x120px, seems poor when user "zooms" \
> the thumbnails 3) sony arw, pentax pef, olympus orf, nikon nrw, fuji raf doesn't \
> seem to contain the small thumb at all 4) nokia dng loads as tiff, full size, but \
> dark and with screwed colours (violet - green)
> Now, all the images supporting the embedded JPEG preview are behaving just as JPEG \
> files with the very little overhead caused by need of extracting the JPEG data from \
> the raw file first (which is instant). From what I see the performance is quite \
> good (comparable to JPEG), there's just the fact, that some of the files have \
> really huge dimensions (like 7360x4912 /36mpx/ from nikon d800). I recently added \
> experimental support for loading downsampled preview from the actual raw data when \
> the embedded preview fails for whatever reason and there's performance drop in such \
> cases, but I consider it better than no support at all. Having this, gwenview can \
> display really everything! :)
>
fixed in v8
- Martin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/#review43083
-----------------------------------------------------------
On Nov. 7, 2013, 3:03 p.m., Martin Kyral wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/113397/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2013, 3:03 p.m.)
>
>
> Review request for Gwenview and Aurélien Gâteau.
>
>
> Repository: gwenview
>
>
> Description
> -------
>
> This is a review of patch enabling raw support in gwenview. It uses KDcraw to \
> extract the embedded jpeg preview (most of the raw formats contain it for the \
> purposes of quick viewing the photos on the camera display) so it is fast, \
> implementing was quite easy and theoretically it enables gwenview to support \
> everything dcraw supports (practically we need to test more formats). The patch \
> does not perform demosaicing and I don't think it shall - digikam, darktable or \
> rawtherapee are much more suited for developing the 'digital negatives'.
> The patch fixes BZ#158788
>
> The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, \
> Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME \
> type to the list in lib/mimetypeutils.cpp shall be enough.
> The patch as is contains just the basic functionality (generating proper thumbnails \
> and viewing the raw images incl. EXIF metadata), but it is well usable. However, \
> there is still a lot of stuff to do (see the commit message in the patch) so I'd \
> appreciate any help.
>
> Diffs
> -----
>
> CMakeLists.txt 4dafb7e
> lib/CMakeLists.txt c6ffe14
> lib/document/loadingdocumentimpl.cpp fbad8ff
> lib/gwenviewconfig.kcfg 231fd5e
> lib/mimetypeutils.cpp 546346f
> lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904
>
> Diff: http://git.reviewboard.kde.org/r/113397/diff/
>
>
> Testing
> -------
>
> Tested on some sample raw files taken from the camera reviews on \
> http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, \
> D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, \
> K30) have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex \
> 6) have only 1616x1050.
>
> Thanks,
>
> Martin Kyral
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113397/">http://git.reviewboard.kde.org/r/113397/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 5th, 2013, 5:04 p.m. UTC, <b>Aurélien \
Gâteau</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/113397/diff/6/?file=206503#file206503line128" \
style="color: black; font-weight: bold; text-decoration: \
underline;">lib/thumbnailprovider/thumbnailgenerator.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 6)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">namespace Gwenview</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">74</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It looks to me like the \
new code is never going to use the embedded thumbnail, this could have a bad impact \
on performance.</pre> </blockquote>
<p>On November 6th, 2013, 9:17 a.m. UTC, <b>Martin Kyral</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yep, it seems so. \
However, using the embedded small thumbnail has some serious drawbacks:
1) there's no particular function in libraw (nor kdcraw), fetching the small size \
thumbnail (unpack_thumb() returns the large preview if present) 2) not every raw file \
contains the small thumb 3) the thumbnail (if any) is always 160x120 (4:3) while \
majority of the raw-enabled cameras shoot 3:2 pictures. That leads to ugly black \
stripes along the longer sides of the thumbnail. 4) the thumbnail view shows the \
160x120 as a resolution of the image (not sure if this can be overriden by exif data \
and how)
I tested various formats with the following results:
1) canon cr2 loads nice big thumbnails even without any additional support in \
gwenview/dolphin. It seems that it behaves as JPEG when loaded which is pretty the \
same as loadEmbeddedPreview does. 2) nikon nef, pentax dnf, leica dng has ugly back \
stripes on the longer sides, reported size 160x120px, seems poor when user \
"zooms" the thumbnails 3) sony arw, pentax pef, olympus orf, nikon nrw, \
fuji raf doesn't seem to contain the small thumb at all 4) nokia dng loads as \
tiff, full size, but dark and with screwed colours (violet - green)
Now, all the images supporting the embedded JPEG preview are behaving just as JPEG \
files with the very little overhead caused by need of extracting the JPEG data from \
the raw file first (which is instant). From what I see the performance is quite good \
(comparable to JPEG), there's just the fact, that some of the files have really \
huge dimensions (like 7360x4912 /36mpx/ from nikon d800). I recently added \
experimental support for loading downsampled preview from the actual raw data when \
the embedded preview fails for whatever reason and there's performance drop in \
such cases, but I consider it better than no support at all. Having this, gwenview \
can display really everything! :)
</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">fixed in \
v8</pre> <br />
<p>- Martin</p>
<br />
<p>On November 7th, 2013, 3:03 p.m. UTC, Martin Kyral wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Gwenview and Aurélien Gâteau.</div>
<div>By Martin Kyral.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2013, 3:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a review of patch enabling raw support in gwenview. It uses \
KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for \
the purposes of quick viewing the photos on the camera display) so it is fast, \
implementing was quite easy and theoretically it enables gwenview to support \
everything dcraw supports (practically we need to test more formats). The patch does \
not perform demosaicing and I don't think it shall - digikam, darktable or \
rawtherapee are much more suited for developing the 'digital negatives'.
The patch fixes BZ#158788
The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, \
Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME \
type to the list in lib/mimetypeutils.cpp shall be enough.
The patch as is contains just the basic functionality (generating proper thumbnails \
and viewing the raw images incl. EXIF metadata), but it is well usable. However, \
there is still a lot of stuff to do (see the commit message in the patch) so I'd \
appreciate any help.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on some sample raw files taken from the camera reviews on \
http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, \
D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) \
have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have \
only 1616x1050.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4dafb7e)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(c6ffe14)</span></li>
<li>lib/document/loadingdocumentimpl.cpp <span style="color: \
grey">(fbad8ff)</span></li>
<li>lib/gwenviewconfig.kcfg <span style="color: grey">(231fd5e)</span></li>
<li>lib/mimetypeutils.cpp <span style="color: grey">(546346f)</span></li>
<li>lib/thumbnailprovider/thumbnailgenerator.cpp <span style="color: \
grey">(8b98904)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113397/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic