[prev in list] [next in list] [prev in thread] [next in thread]
List: gwenview-devel
Subject: Re: Review Request 113397: RAW preview in gwenview
From: "Martin Kyral" <martin.kyral () gmail ! com>
Date: 2013-11-07 15:03:22
Message-ID: 20131107150322.30384.41539 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113397/
-----------------------------------------------------------
(Updated Nov. 7, 2013, 3:03 p.m.)
Review request for Gwenview and Aurélien Gâteau.
Changes
-------
Fixes of the review remarks
Repository: gwenview
Description
-------
This is a review of patch enabling raw support in gwenview. It uses KDcraw to extract \
the embedded jpeg preview (most of the raw formats contain it for the purposes of \
quick viewing the photos on the camera display) so it is fast, implementing was quite \
easy and theoretically it enables gwenview to support everything dcraw supports \
(practically we need to test more formats). The patch does not perform demosaicing \
and I don't think it shall - digikam, darktable or rawtherapee are much more suited \
for developing the 'digital negatives'.
The patch fixes BZ#158788
The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, \
Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME type \
to the list in lib/mimetypeutils.cpp shall be enough.
The patch as is contains just the basic functionality (generating proper thumbnails \
and viewing the raw images incl. EXIF metadata), but it is well usable. However, \
there is still a lot of stuff to do (see the commit message in the patch) so I'd \
appreciate any help.
Diffs (updated)
-----
CMakeLists.txt 4dafb7e
lib/CMakeLists.txt c6ffe14
lib/document/loadingdocumentimpl.cpp fbad8ff
lib/gwenviewconfig.kcfg 231fd5e
lib/mimetypeutils.cpp 546346f
lib/thumbnailprovider/thumbnailgenerator.cpp 8b98904
Diff: http://git.reviewboard.kde.org/r/113397/diff/
Testing
-------
Tested on some sample raw files taken from the camera reviews on \
http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, \
D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) \
have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have \
only 1616x1050.
Thanks,
Martin Kyral
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113397/">http://git.reviewboard.kde.org/r/113397/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Gwenview and Aurélien Gâteau.</div>
<div>By Martin Kyral.</div>
<p style="color: grey;"><i>Updated Nov. 7, 2013, 3:03 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixes of the review remarks</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
gwenview
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a review of patch enabling raw support in gwenview. It uses \
KDcraw to extract the embedded jpeg preview (most of the raw formats contain it for \
the purposes of quick viewing the photos on the camera display) so it is fast, \
implementing was quite easy and theoretically it enables gwenview to support \
everything dcraw supports (practically we need to test more formats). The patch does \
not perform demosaicing and I don't think it shall - digikam, darktable or \
rawtherapee are much more suited for developing the 'digital negatives'.
The patch fixes BZ#158788
The patch enables support for Nikon NEF and NRW formats, Canon's CR2, Pentax PEF, \
Sony ARW and Adobe DNG. If you want to try another format, just adding it's MIME \
type to the list in lib/mimetypeutils.cpp shall be enough.
The patch as is contains just the basic functionality (generating proper thumbnails \
and viewing the raw images incl. EXIF metadata), but it is well usable. However, \
there is still a lot of stuff to do (see the commit message in the patch) so I'd \
appreciate any help.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Tested on some sample raw files taken from the camera reviews on \
http://www.photographyblog.com/ and bunch of my own photos. Nikon (tried D50, D70s, \
D90, D800 and Coolpix P7000), Canon (tried 7D, 5D Mark3 and 6D) and Pentax (K-X, K30) \
have the preview full-res, while Sony raw files (A900, A850, A58, Nex 3, Nex 6) have \
only 1616x1050.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4dafb7e)</span></li>
<li>lib/CMakeLists.txt <span style="color: grey">(c6ffe14)</span></li>
<li>lib/document/loadingdocumentimpl.cpp <span style="color: \
grey">(fbad8ff)</span></li>
<li>lib/gwenviewconfig.kcfg <span style="color: grey">(231fd5e)</span></li>
<li>lib/mimetypeutils.cpp <span style="color: grey">(546346f)</span></li>
<li>lib/thumbnailprovider/thumbnailgenerator.cpp <span style="color: \
grey">(8b98904)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113397/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Gwenview-devel mailing list
Gwenview-devel@kde.org
https://mail.kde.org/mailman/listinfo/gwenview-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic