[prev in list] [next in list] [prev in thread] [next in thread] 

List:       glibc-alpha
Subject:    Re: -Wundef fixes
From:       Joseph Myers <joseph () codesourcery ! com>
Date:       2014-12-30 17:35:44
Message-ID: alpine.DEB.2.10.1412301733180.17381 () digraph ! polyomino ! org ! uk
[Download RAW message or body]

On Mon, 29 Dec 2014, Siddhesh Poyarekar wrote:

> Hi,
> 
> I have checked in patches to fix the remaining -Wundef warnings, so
> now the build log should be clean for most configurations.  I had
> noticed the odd -Wundef warning on other architectures, which I'll
> have a more clear report on once my cross-builds are complete.

Once the build *and test* is free of -Wundef warnings for at least one 
configuration, -Wno-error=undef should be removed.  For a test run on 
x86_64 I currently see:

In file included from tst-utmpx.c:2:0:
tst-utmp.c:42:5: warning: "_HAVE_UT_TYPE" is not defined [-Wundef]
 #if _HAVE_UT_TYPE || defined UTMPX
     ^
In file included from tst-utmpx.c:2:0:
tst-utmp.c:78:5: warning: "_HAVE_UT_TV" is not defined [-Wundef]
 #if _HAVE_UT_TV || defined UTMPX
     ^
tst-utmp.c: In function 'simulate_login':
tst-utmp.c:170:5: warning: "_HAVE_UT_TV" is not defined [-Wundef]
 #if _HAVE_UT_TV - 0 || defined UTMPX
     ^
tst-utmp.c: In function 'simulate_logout':
tst-utmp.c:204:5: warning: "_HAVE_UT_TV" is not defined [-Wundef]
 #if _HAVE_UT_TV - 0 || defined UTMPX
     ^

and

tst-execstack.c:25:5: warning: "USE_PTHREADS" is not defined [-Wundef]
 #if USE_PTHREADS
     ^
tst-execstack.c: In function 'do_test':
tst-execstack.c:88:5: warning: "USE_PTHREADS" is not defined [-Wundef]
 #if USE_PTHREADS
     ^
tst-execstack.c:110:5: warning: "USE_PTHREADS" is not defined [-Wundef]
 #if USE_PTHREADS
     ^
tst-execstack.c:161:5: warning: "USE_PTHREADS" is not defined [-Wundef]
 #if USE_PTHREADS
     ^
tst-execstack.c:206:5: warning: "USE_PTHREADS" is not defined [-Wundef]
 #if USE_PTHREADS
     ^

-- 
Joseph S. Myers
joseph@codesourcery.com
[prev in list] [next in list] [prev in thread] [next in thread]