[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH v5 0/6] cat-file: add --batch-command remote-object-info command
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2022-09-30 23:23:58
Message-ID: xmqqedvs78fl.fsf () gitster ! g
[Download RAW message or body]

Calvin Wan <calvinwan@google.com> writes:

> Sometimes it is useful to get information about an object without having
> to download it completely. The server logic has already been implemented
> as "a2ba162cda (object-info: support for retrieving object info,
> 2021-04-20)". This patch implements the client option for it.
>
> Add `--object-info` option to `cat-file --batch-command`. This option
> allows the client to make an object-info command request to a server
> that supports protocol v2. If the server is v2, but does not allow for
> the object-info command request, the entire object is fetched and the
> relevant object info is returned.
>
> === Changes since v4 ===
>  - Instead of making 2 rounds trips to determine whether the server can
>    handle the client object-info request, the server now advertises the
>    features it can send back so the client can immediately fallback to
>    fetch if any feature is not supported
>  - Fixed nits and clarified some documentation/commit messages
>
> Signed-off-by: Calvin Wan <calvinwan@google.com>
> Helped-by: Jonathan Tan <jonathantanmy@google.com>

FWIW, this one seems to make t1006 fail under SANITIZE=address, i.e.

    $ SANITIZE=address make test

I thought it would be better to report this before you send out v6
after the release.

Thanks.
[prev in list] [next in list] [prev in thread] [next in thread]