[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: [PATCH] branch: do not fail a no-op --edit-desc
From:       Rubén_Justo <rjusto () gmail ! com>
Date:       2022-09-30 22:59:48
Message-ID: 0c875ba3-f2cd-7fe1-3192-7759e5cebdb7 () gmail ! com
[Download RAW message or body]

On 30/9/22 0:26, Junio C Hamano wrote:

>> And.. the message does not make it clear the situation: if there is
>> a previous description, will clear; if not, will keep.
> 
> If there is a previous description, then we use the behaviour we
> have had for ages (i.e. will remove).  If there is not a previous
> description, then we use the new behaviour (i.e. not attempt to
> remove and hence we do not show an error).  Either way, the end
> result is "the user indicated they do not want description by giving
> us an empty edit result.  After the command exits, the branch has no
> description".  

I was not clear, sorry.  I was referring just to the concurrent-editors
circumstance.

I find your last paragraph in the message might suggest that in case of 
concurrent editions, the last one won't overwrite if exits with an 
empty description.  But it will if the branch had a previous branch
description when that last execution started.  You might want the reader
to assume that the example follows the initial description "on a branch
without branch description", in that case everything is fine.

That was what I was trying to review.  The usage and why the error is
avoided is well explained.  And better in your v3, imo.

Thank you.

Un saludo.
[prev in list] [next in list] [prev in thread] [next in thread]