[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: janitoring
From:       Pierre Habouzit <madcoder () madism ! org>
Date:       2009-07-22 22:02:09
Message-ID: 20090722220209.GE13823 () artemis ! corp
[Download RAW message or body]

On Wed, Jul 22, 2009 at 03:00:21PM -0700, Junio C Hamano wrote:
> Pierre Habouzit <madcoder@debian.org> writes:
> 
> > [PATCH 1/3] janitor: use NULL and not 0 for pointers.
> >
> >   I really dislike the use of 0 when NULL is meant. This patch probably
> >   fixes most of them. The biggest culprit is nedmalloc, but a few
> >   remnants exist in plain git code.
> 
> I am not enthused about "fixing" borrowed foreign code, unless we know
> that we are committed to support our fork.  My impression was that this
> ned stuff was borrowed by the MinGW folks with the understanding that we
> will slurp it with minimum modification and turn a blind eye to its
> sub-par coding styles, so that it can be more easily updated from the
> upstream?

Okay, maybe the 2-3 hunks that don't apply to nedmalloc stuff can be
saved though, do you want me to send an updated patch ?

-- 
Intersec <http://www.intersec.com>
Pierre Habouzit <pierre.habouzit@intersec.com>
Tél : +33 (0)1 5570 3346
Mob : +33 (0)6 1636 8131
Fax : +33 (0)1 5570 3332
37 Rue Pierre Lhomme
92400 Courbevoie

["signature.asc" (application/pgp-signature)]
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[prev in list] [next in list] [prev in thread] [next in thread]