[prev in list] [next in list] [prev in thread] [next in thread] 

List:       git
Subject:    Re: janitoring
From:       Junio C Hamano <gitster () pobox ! com>
Date:       2009-07-22 22:00:21
Message-ID: 7vws60cr9m.fsf () alter ! siamese ! dyndns ! org
[Download RAW message or body]

Pierre Habouzit <madcoder@debian.org> writes:

> [PATCH 1/3] janitor: use NULL and not 0 for pointers.
>
>   I really dislike the use of 0 when NULL is meant. This patch probably
>   fixes most of them. The biggest culprit is nedmalloc, but a few
>   remnants exist in plain git code.

I am not enthused about "fixing" borrowed foreign code, unless we know
that we are committed to support our fork.  My impression was that this
ned stuff was borrowed by the MinGW folks with the understanding that we
will slurp it with minimum modification and turn a blind eye to its
sub-par coding styles, so that it can be more easily updated from the
upstream?

--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[prev in list] [next in list] [prev in thread] [next in thread]