[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] eclass/java-utils-2.eclass: testng print verbose output
From:       Florian Schmaus <flow () gentoo ! org>
Date:       2022-06-29 6:48:40
Message-ID: bd5e57bd-b3a7-5ff2-b822-e2248d757552 () gentoo ! org
[Download RAW message or body]

On 28/06/2022 19.04, Volkmar W. Pogatzki wrote:
> Bug: https://bugs.gentoo.org/801694
> Signed-off-by: Volkmar W. Pogatzki <gentoo@pogatzki.net>
> ---
> eclass/java-utils-2.eclass | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/eclass/java-utils-2.eclass b/eclass/java-utils-2.eclass
> index e5a2b611d11..cfe04d631a0 100644
> --- a/eclass/java-utils-2.eclass
> +++ b/eclass/java-utils-2.eclass
> @@ -1901,7 +1901,9 @@ etestng() {
> 		${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}
> 	)
> 
> -	[[ ! "${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}" =~ "-usedefaultlisteners" ]] && args+=( \
> -usedefaultlisteners false ) +	if [[ ! "${JAVA_TEST_RUNNER_EXTRA_ARGS[@]}" =~ \
> "-usedefaultlisteners" ]]; then +		args+=( -verbose 3 -usedefaultlisteners true )
> +	fi
> 
> 	args+=( -testclass ${tests} )

LGTM, but I would split the args value in multiple lines, which makes it 
clear what the argument name and the argument value is and hence makes 
it easier to read:

args+=(
	-verbose 3
	-usedefaultlisteners true
)

- Flow


[prev in list] [next in list] [prev in thread] [next in thread]