[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] [PATCH] epatch.eclass: call ebegin to balance eend
From:       Mike Gilbert <floppym () gentoo ! org>
Date:       2022-06-28 18:08:46
Message-ID: CAJ0EP401QLqmmPVQ10dp710jf+O_x7t53_Oops4fa-EPf49Jiw () mail ! gmail ! com
[Download RAW message or body]

On Tue, Jun 28, 2022 at 2:05 AM Ulrich Mueller <ulm@gentoo.org> wrote:
>
> >>>>> On Mon, 27 Jun 2022, Mike Gilbert wrote:
>
> >               if [[ ${SINGLE_PATCH} == "yes" ]] ; then
> >                       if [[ -n ${EPATCH_SINGLE_MSG} ]] ; then
> > -                             einfo "${EPATCH_SINGLE_MSG}"
> > +                             ebegin "${EPATCH_SINGLE_MSG}"
> >                       else
> > -                             einfo "Applying ${patchname} ..."
> > +                             ebegin "Applying ${patchname}"
> >                       fi
>
> EPATCH_SINGLE_MSG isn't used in the tree, so this could be simplified to
> have the "else" part only, and delete the eclass variable. (Strange idea
> to make this message configurable, in the first place.)
>
> >               else
> > -                     einfo "  ${patchname} ..."
> > +                     ebegin "  ${patchname}"
> >               fi
>
> Maybe drop support for EAPIs 0 to 4 while at it?

I made both changes on the github PR.

https://github.com/gentoo/gentoo/pull/26122

[prev in list] [next in list] [prev in thread] [next in thread]