[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    [gentoo-dev] Re: [PATCH] epatch.eclass: drop 'estach.eclass' usage
From:       Sergei Trofimovich <slyfox () gentoo ! org>
Date:       2018-08-18 23:30:04
Message-ID: 20180819003004.5a227066 () sf
[Download RAW message or body]

On Sat, 11 Aug 2018 01:02:23 +0100
Sergei Trofimovich <slyfox@gentoo.org> wrote:

> Avoid use of eshopts_push / eshopts_pop functions
> as they don't preserve expand_aliases shell option
> and get detected by QA warning as:
>   * QA Notice: Global shell options changed and were
>   not restored while calling 'src_prepare'
> 
> Ssee bug #662586 for details.
> 
> Tested as:
>     $ EPATCH_USER_EXCLUDE="*" ebuild gcc-8.2.0.ebuild clean prepare
> 
> CC: mgorny@gentoo.org
> CC: base-system@gentoo.org
> Bug: https://bugs.gentoo.org/662586
> Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
> ---
>  eclass/epatch.eclass | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)

Pushed as:
    https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b21e386a064e1ed49981d9527f968ddc5e1eeb86

-- 

  Sergei

[prev in list] [next in list] [prev in thread] [next in thread]