[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gentoo-dev
Subject:    Re: [gentoo-dev] ldconfig symlink updates -- do we need that?
From:       Michał Górny <mgorny () gentoo ! org>
Date:       2011-06-28 15:43:47
Message-ID: 20110628174347.198eebb2 () pomiocik ! lan
[Download RAW message or body]


On Tue, 28 Jun 2011 17:31:11 +0200
Cyprien Nicolas <c.nicolas@gmail.com> wrote:

> On 28/06/11 10:53, Michał Górny wrote:
> > On Tue, 28 Jun 2011 10:48:48 +0200 Michał Górny <mgorny@gentoo.org> 
> > wrote:
> 
> I'm a noob in Python, but I disagree with this patch. for two reasons:
> 
> First, the -X option is already available, and controlled by
> makelinks, so why not change the default value of makelinks to False?
> 
> Second, after trying to understand the code, if your proposed patch is
> applied, the makelinks variable become useless. So why not remove it
> completly from the source? Is this variable still needed?
> 
> There is some bunch of code starting at line 222 in the current HEAD,
> which sets makelinks to False upon some conditions, does this need to
> be refactored / removed somehow too?

This patch is just the simplest approach to see if it works as
expected. We'll prepare a better/more consistent patch when the concept
itself is accepted.

-- 
Best regards,
Michał Górny

["signature.asc" (application/pgp-signature)]

[prev in list] [next in list] [prev in thread] [next in thread]