[prev in list] [next in list] [prev in thread] [next in thread] 

List:       gallery-devel
Subject:    Re: [Gallery-devel] HTML_Safe + UTF-7
From:       Bharat Mediratta <bharat () menalto ! com>
Date:       2006-04-20 5:35:33
Message-ID: 44471DA5.1070209 () menalto ! com
[Download RAW message or body]


Just for the record (since I already approved this in irc and Alan 
submitted it), this looks good to me.

-Bharat

Alan Harder wrote:
> http://gallery.menalto.com/node/47878
> 
> For some reason HTML_Safe has some handling for UTF-7.
> http://www.ietf.org/rfc/rfc2152.txt
> 
> So a string like +Jjo- is a smiley face in UTF-7.
> HTML_Safe will decode and recode strings like this that
> are valid UTF-7 (the stuff between + and - needs to be
> base64_decode-able, I guess).. but something like +b-
> ends up just getting stripped, so:
> GalleryUtilities::htmlSafe('a+b-c');
> produces 'ac'
> I filed a bug on the PEAR site, link posted in that forum topic.
> 
> 
> For G2 I plan to comment out this line:
>        $doc = $this->repackUTF7($doc);
> in function parse().  I don't expect any UTF-7 data, so this
> seems unnecessary.. I can't think of how the presence of
> invalid UTF-7 like +b- could make the text "unsafe".
> Any objections or comments on this change?
> Thanks,
> 
>     - Alan
> 
> 
> -------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job 
> easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> __[ g a l l e r y - d e v e l ]_________________________
> 
> [ list info/archive --> http://gallery.sf.net/lists.php ]
> [ gallery info/FAQ/download --> http://gallery.sf.net ]




-------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
__[ g a l l e r y - d e v e l ]_________________________

[ list info/archive --> http://gallery.sf.net/lists.php ]
[ gallery info/FAQ/download --> http://gallery.sf.net ]
[prev in list] [next in list] [prev in thread] [next in thread]