[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] iASL: Use ACPI_COMPARE_NAMESEG instead of strcmp
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2019-11-14 2:08:01
Message-ID: 7356f7ac-4e2c-24c5-2a67-274e44451a36 () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On 11/12/19 10:29 PM, Colin King wrote:
> From: Robert Moore <Robert.Moore@intel.com>
>
> BugLink: https://bugs.launchpad.net/bugs/1819968
>
> For _HID, _CID processing. Reported by Benjamin Berg
> (benjamin@sipsolutions.net).
>
> (backport from ACPICA upstream commit 3dcd13aa62e7)
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  src/acpica/source/compiler/aslmethod.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/acpica/source/compiler/aslmethod.c b/src/acpica/source/compiler/aslmethod.c
> index 667eaaaf..4b29fc9e 100644
> --- a/src/acpica/source/compiler/aslmethod.c
> +++ b/src/acpica/source/compiler/aslmethod.c
> @@ -586,7 +586,7 @@ MtMethodAnalysisWalkBegin (
>  
>          /* Special typechecking for _HID */
>  
> -        if (!strcmp (METHOD_NAME__HID, Op->Asl.NameSeg))
> +        if (ACPI_COMPARE_NAMESEG (METHOD_NAME__HID, Op->Asl.NameSeg))
>          {
>              Next = Op->Asl.Child->Asl.Next;
>              AnCheckId (Next, ASL_TYPE_HID);
> @@ -594,7 +594,7 @@ MtMethodAnalysisWalkBegin (
>  
>          /* Special typechecking for _CID */
>  
> -        else if (!strcmp (METHOD_NAME__CID, Op->Asl.NameSeg))
> +        else if (ACPI_COMPARE_NAMESEG (METHOD_NAME__CID, Op->Asl.NameSeg))
>          {
>              Next = Op->Asl.Child->Asl.Next;
>  

Acked-by: Ivan Hu <ivan.hu@canonical.com>



["signature.asc" (application/pgp-signature)]
[Attachment #8 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread]