[prev in list] [next in list] [prev in thread] [next in thread] 

List:       fwts-devel
Subject:    ACK: [PATCH] sbbr: add uefi tests to ARM's SBBR
From:       ivanhu <ivan.hu () canonical ! com>
Date:       2019-11-14 2:05:08
Message-ID: c2f10fc9-de6c-f476-8f99-98ec8ea8ba0b () canonical ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


On 11/9/19 2:18 AM, Alex Hung wrote:
> Similar to EBBR, SBBR also includes a set of required UEFI runtime
> services. See more details in "APPENDIX B REQUIRED UEFI RUNTIME
> SERVICES" in Arm Server Base Boot Requirements.
> 
> Signed-off-by: Alex Hung <alex.hung@canonical.com>
> ---
> src/lib/include/fwts_framework.h         | 3 ++-
> src/uefi/uefirtmisc/uefirtmisc.c         | 2 +-
> src/uefi/uefirttime/uefirttime.c         | 2 +-
> src/uefi/uefirtvariable/uefirtvariable.c | 2 +-
> 4 files changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/lib/include/fwts_framework.h b/src/lib/include/fwts_framework.h
> index 74e12657..808bcd62 100644
> --- a/src/lib/include/fwts_framework.h
> +++ b/src/lib/include/fwts_framework.h
> @@ -62,7 +62,8 @@ typedef enum {
> 	FWTS_FLAG_SHOW_TESTS_CATEGORIES		= 0x00400000,
> 	FWTS_FLAG_TEST_COMPLIANCE_ACPI		= 0x00800000,
> 	FWTS_FLAG_TEST_SBBR			= 0x01000000,
> -	FWTS_FLAG_TEST_EBBR			= 0x02000000
> +	FWTS_FLAG_TEST_EBBR			= 0x02000000,
> +	FWTS_FLAG_TEST_XBBR			= FWTS_FLAG_TEST_SBBR | FWTS_FLAG_TEST_EBBR
> } fwts_framework_flags;
> 
> #define FWTS_FLAG_TEST_MASK		\
> diff --git a/src/uefi/uefirtmisc/uefirtmisc.c b/src/uefi/uefirtmisc/uefirtmisc.c
> index a0a4c4cc..0b14aa8a 100644
> --- a/src/uefi/uefirtmisc/uefirtmisc.c
> +++ b/src/uefi/uefirtmisc/uefirtmisc.c
> @@ -347,6 +347,6 @@ static fwts_framework_ops uefirtmisc_ops = {
> 	.minor_tests = uefirtmisc_tests
> };
> 
> -FWTS_REGISTER("uefirtmisc", &uefirtmisc_ops, FWTS_TEST_ANYTIME, \
> FWTS_FLAG_TEST_UEFI | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_EBBR) \
> +FWTS_REGISTER("uefirtmisc", &uefirtmisc_ops, FWTS_TEST_ANYTIME, \
> FWTS_FLAG_TEST_UEFI | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_XBBR) \
>  #endif
> diff --git a/src/uefi/uefirttime/uefirttime.c b/src/uefi/uefirttime/uefirttime.c
> index d1446f22..163080e4 100644
> --- a/src/uefi/uefirttime/uefirttime.c
> +++ b/src/uefi/uefirttime/uefirttime.c
> @@ -1441,6 +1441,6 @@ static fwts_framework_ops uefirttime_ops = {
> 	.minor_tests = uefirttime_tests
> };
> 
> -FWTS_REGISTER("uefirttime", &uefirttime_ops, FWTS_TEST_ANYTIME, \
> FWTS_FLAG_TEST_UEFI | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_EBBR) \
> +FWTS_REGISTER("uefirttime", &uefirttime_ops, FWTS_TEST_ANYTIME, \
> FWTS_FLAG_TEST_UEFI | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_XBBR) \
>  #endif
> diff --git a/src/uefi/uefirtvariable/uefirtvariable.c \
> b/src/uefi/uefirtvariable/uefirtvariable.c index cb17f973..51aabfd5 100644
> --- a/src/uefi/uefirtvariable/uefirtvariable.c
> +++ b/src/uefi/uefirtvariable/uefirtvariable.c
> @@ -2378,6 +2378,6 @@ static fwts_framework_ops uefirtvariable_ops = {
> 	.options_check   = options_check,
> };
> 
> -FWTS_REGISTER("uefirtvariable", &uefirtvariable_ops, FWTS_TEST_ANYTIME, \
> FWTS_FLAG_TEST_UEFI | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_EBBR) \
> +FWTS_REGISTER("uefirtvariable", &uefirtvariable_ops, FWTS_TEST_ANYTIME, \
> FWTS_FLAG_TEST_UEFI | FWTS_FLAG_UNSAFE | FWTS_FLAG_ROOT_PRIV | FWTS_FLAG_TEST_XBBR) \
>  #endif


Acked-by: Ivan Hu <ivan.hu@canonical.com>


["signature.asc" (application/pgp-signature)]
[Attachment #8 (text/plain)]

-- 
fwts-devel mailing list
fwts-devel@lists.ubuntu.com
Modify settings or unsubscribe at: https://lists.ubuntu.com/mailman/listinfo/fwts-devel


[prev in list] [next in list] [prev in thread] [next in thread]