[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freeradius-users
Subject:    Re: postgresql driver loads! (was: postgresql driver not linking)
From:       Yury Bokhoncovich <byg () center-f1 ! ru>
Date:       2001-03-22 5:17:56
[Download RAW message or body]

Hello!
On Thu, 15 Mar 2001, Bernhard Reiter wrote:

Small patch to eliminate warning and to do the right cast, also to remove
redundant (useless) code
==================
--- src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c.orig
Wed Mar 21 12:06:57 2001
+++ src/modules/rlm_sql/drivers/rlm_sql_postgresql/sql_postgresql.c
Wed Mar 21 12:12:57 2001
@@ -231,10 +231,8 @@
                                xfree(pg_sock->row[i]);
                        }
                }
-               if (pg_sock->row != NULL) {
-                       xfree(pg_sock->row);
-                       pg_sock->row = NULL;
-               }
+               xfree((char*)pg_sock->row);
+               pg_sock->row = NULL;
                pg_sock->num_fields = 0;
        }
===================
> Found two outstanding bugs in the configuration system:
> 	- The drivers for rlm_sql are not made when
> 	issuing a top level make
Yep. This still causes troubles in my typical RH configuration: PGSQL
compiled with --prefix=/usr so include files live in /usr/include and
libraries live in /usr/lib.
Solved by manual editing of top-level Makefile though this is quick dirty
fix for me only.
-- 
WBR, Yury Bokhoncovich, System Administrator, NOC of F1 Group.
Phone: +7 (3832) 106228, ext.140, E-mail: byg@center-f1.ru.
Unix is like a wigwam -- no Gates, no Windows, and an Apache inside.




[prev in list] [next in list] [prev in thread] [next in thread]