[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freenx-knx
Subject:    Re: [FreeNX-kNX] freenx-client 0.9 feedback
From:       Johnny Hughes <mailing-lists () hughesjr ! com>
Date:       2008-04-12 18:43:28
Message-ID: 480102D0.3020702 () hughesjr ! com
[Download RAW message or body]

[Attachment #2 (multipart/signed)]

[Attachment #4 (multipart/mixed)]


Dirk Mueller wrote:
> Hi, 
> 
> some feedback from trying to build freenx-client 0.9 release:
> 
> a) it does not build with gcc 4.3. see attached patch
> 
> b) qtnx can still not install itself. see other attached patch
> 
> c) as qtnx needs pkgconfig to resolve the libnxcl, which is built in the other 
> subdir, I think it would cause less pain for the packagers of those two sub 
> directory would be separated in different tarballs. They don't share a common 
> build system anyway. 
> 
> d) the source code claims to be GPL v2+. GPL however requires to ship a GPL 
> license in a file named COPYING as part of the package. this doesn't seem to 
> be the case. Please clarify the actual license of the code. Also, list of 
> authors etc is missing as well, but I fetched them from the actual source 
> file.
> 
> e) the autoconf/automake requires of libnxcl are extremely high, while it 
> seems to build just fine with older version of autotools, once those are 
> fixed. Is there a reason for that? this is a problem for older distributions.

Also, we (CentOS) needed to add 2 patches to this to get the "id.key" to 
work properly (that is to be read out of the nxml files and not out of a 
`pwd`/id.key file.

nxcl-chmod-600-keyid.patch changes the key created in /tmp/ to 600

qtnx-multiple-id-key.patch uses the key created in the /tmp/ dir (from 
your nxml file) if it exists, and if not then looks for `pwd`/id.key

Thanks,
Johnny Hughes

["nxcl-chmod-600-keyid.patch" (text/x-patch)]

--- nxcl/lib/notQt.cpp.bad
+++ nxcl/lib/notQt.cpp
@@ -339,6 +339,9 @@
     fn << "/tmp/notQt" << time(NULL);
     this->theFileName = fn.str();
     this->f.open (this->theFileName.c_str(), ios::in|ios::out|ios::trunc);
+    if (chmod(this->theFileName.c_str(), S_IRUSR | S_IWUSR) == -1) {
+        perror("chmod");
+    }
 }
 
     void

["qtnx-multiple-id-key.patch" (text/x-patch)]

--- qtnx/qtnxwindow.cpp.bad
+++ qtnx/qtnxwindow.cpp
@@ -273,8 +273,9 @@
     if (!config.key.empty()) {
         key = config.key;
         session.key = "supplied";
-    } else
-        session.key = "default";
+    } else
+        session.key = "id.key";
+	
 
     if (config.sessionType == "unix-application")
         session.customCommand = config.customCommand;
@@ -290,13 +291,12 @@
 
     m_NXClient->setDepth(getDepth());
 
-    QString keyPath = "id.key";
 
 #ifdef Q_WS_MAC
     keyPath = binaryPath + "/id.key";
 #endif
 
-    m_NXClient->invokeNXSSH(keyPath.toStdString(), config.serverHost, config.encryption, "",
+    m_NXClient->invokeNXSSH(session.key, config.serverHost, config.encryption, config.key,
             config.serverPort);
 
     processProbe->start(30);

["signature.asc" (application/pgp-signature)]

________________________________________________________________
     Were you helped on this list with your FreeNX problem?
    Then please write up the solution in the FreeNX Wiki/FAQ:
  http://openfacts.berlios.de/index-en.phtml?title=FreeNX_FAQ
         Don't forget to check the NX Knowledge Base:
                 http://www.nomachine.com/kb/ 

________________________________________________________________
       FreeNX-kNX mailing list --- FreeNX-kNX@kde.org
      https://mail.kde.org/mailman/listinfo/freenx-knx
________________________________________________________________

[prev in list] [next in list] [prev in thread] [next in thread]