From freenx-knx  Sat Apr 12 18:43:28 2008
From: Johnny Hughes <mailing-lists () hughesjr ! com>
Date: Sat, 12 Apr 2008 18:43:28 +0000
To: freenx-knx
Subject: Re: [FreeNX-kNX] freenx-client 0.9 feedback
Message-Id: <480102D0.3020702 () hughesjr ! com>
X-MARC-Message: https://marc.info/?l=freenx-knx&m=120802586323562
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0371948764=="

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--===============0371948764==
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enigB0EB6D89244D8E72707D5338"

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigB0EB6D89244D8E72707D5338
Content-Type: multipart/mixed;
 boundary="------------070107000806000800010804"

This is a multi-part message in MIME format.
--------------070107000806000800010804
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: quoted-printable

Dirk Mueller wrote:
> Hi,=20
>=20
> some feedback from trying to build freenx-client 0.9 release:
>=20
> a) it does not build with gcc 4.3. see attached patch
>=20
> b) qtnx can still not install itself. see other attached patch
>=20
> c) as qtnx needs pkgconfig to resolve the libnxcl, which is built in th=
e other=20
> subdir, I think it would cause less pain for the packagers of those two=
 sub=20
> directory would be separated in different tarballs. They don't share a =
common=20
> build system anyway.=20
>=20
> d) the source code claims to be GPL v2+. GPL however requires to ship a=
 GPL=20
> license in a file named COPYING as part of the package. this doesn't se=
em to=20
> be the case. Please clarify the actual license of the code. Also, list =
of=20
> authors etc is missing as well, but I fetched them from the actual sour=
ce=20
> file.
>=20
> e) the autoconf/automake requires of libnxcl are extremely high, while =
it=20
> seems to build just fine with older version of autotools, once those ar=
e=20
> fixed. Is there a reason for that? this is a problem for older distribu=
tions.

Also, we (CentOS) needed to add 2 patches to this to get the "id.key" to =

work properly (that is to be read out of the nxml files and not out of a =

`pwd`/id.key file.

nxcl-chmod-600-keyid.patch changes the key created in /tmp/ to 600

qtnx-multiple-id-key.patch uses the key created in the /tmp/ dir (from=20
your nxml file) if it exists, and if not then looks for `pwd`/id.key

Thanks,
Johnny Hughes

--------------070107000806000800010804
Content-Type: text/x-patch;
 name="nxcl-chmod-600-keyid.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
 filename="nxcl-chmod-600-keyid.patch"

--- nxcl/lib/notQt.cpp.bad
+++ nxcl/lib/notQt.cpp
@@ -339,6 +339,9 @@
     fn << "/tmp/notQt" << time(NULL);
     this->theFileName =3D fn.str();
     this->f.open (this->theFileName.c_str(), ios::in|ios::out|ios::trunc=
);
+    if (chmod(this->theFileName.c_str(), S_IRUSR | S_IWUSR) =3D=3D -1) {=

+        perror("chmod");
+    }
 }
=20
     void

--------------070107000806000800010804
Content-Type: text/x-patch;
 name="qtnx-multiple-id-key.patch"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline;
 filename="qtnx-multiple-id-key.patch"

--- qtnx/qtnxwindow.cpp.bad
+++ qtnx/qtnxwindow.cpp
@@ -273,8 +273,9 @@
     if (!config.key.empty()) {
         key =3D config.key;
         session.key =3D "supplied";
-    } else
-        session.key =3D "default";
+    } else
+        session.key =3D "id.key";
+=09
=20
     if (config.sessionType =3D=3D "unix-application")
         session.customCommand =3D config.customCommand;
@@ -290,13 +291,12 @@
=20
     m_NXClient->setDepth(getDepth());
=20
-    QString keyPath =3D "id.key";
=20
 #ifdef Q_WS_MAC
     keyPath =3D binaryPath + "/id.key";
 #endif
=20
-    m_NXClient->invokeNXSSH(keyPath.toStdString(), config.serverHost, co=
nfig.encryption, "",
+    m_NXClient->invokeNXSSH(session.key, config.serverHost, config.encry=
ption, config.key,
             config.serverPort);
=20
     processProbe->start(30);

--------------070107000806000800010804--

--------------enigB0EB6D89244D8E72707D5338
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIAQLQTKkMgmrBY7MRAoxXAJ0SvUE3wB2Ffv79QTL03DBzZf8abACgjiM5
ncybnadc7F3B20ErYlkb+HE=
=IKnv
-----END PGP SIGNATURE-----

--------------enigB0EB6D89244D8E72707D5338--

--===============0371948764==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

________________________________________________________________
     Were you helped on this list with your FreeNX problem?
    Then please write up the solution in the FreeNX Wiki/FAQ:
  http://openfacts.berlios.de/index-en.phtml?title=FreeNX_FAQ
         Don't forget to check the NX Knowledge Base:
                 http://www.nomachine.com/kb/ 

________________________________________________________________
       FreeNX-kNX mailing list --- FreeNX-kNX@kde.org
      https://mail.kde.org/mailman/listinfo/freenx-knx
________________________________________________________________
--===============0371948764==--