[prev in list] [next in list] [prev in thread] [next in thread]
List: freedesktop-xorg-devel
Subject: Re: [PATCH xkeyboard-config] Add evdev mappings for KEY_SOUND, KEY_UWB, KEY_WWAN and KEY_RFKILL
From: Sergey Udaltsov <sergey.udaltsov () gmail ! com>
Date: 2017-05-15 14:59:46
Message-ID: CAHiMruMYL=GFONV_+PCk+d=TvOT2Y8k_qdbf4UaAUXWt29_1Fg () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
Hi Hans
I can push, of course, if the mutual consensus is that now is the right
time for it.
Cheers
Sergey
On Mon, May 15, 2017 at 8:26 AM, Hans de Goede <hdegoede@redhat.com> wrote:
> Hi,
>
> On 15-05-17 03:06, Peter Hutterer wrote:
>
>> adding svu to CC:
>>
>> On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote:
>>
>>> KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual devices and
>>> current xproto master defines keysyms for these. Add mappings for
>>> these keys.
>>>
>>> The XF86UWB keysm exists for quite a while now, as does the KEY_SOUND
>>> evdev code for it, so lets adds a mapping for that too.
>>>
>>> Note that this replaces the I255 to XF86Hibernate mapping in
>>> xkb_symbols "evdev", I don't know where that came from, but it is
>>> wrong, I255 was until now not defined in keycodes/evdev and
>>> KEY_HIBERNATE is not defined in linux/input-event-codes.h .
>>>
>>
>> see xk-c commit 7b3bfb3ec4b, has a link to the thread. After a bit of
>> digging, this got merged into dmitry's next tree (see
>> https://patchwork.kernel.org/patch/9742/) but never ended up in master.
>> My email archives trail out from there and I'm not sure what exactly
>> happens, google isn't forthcoming either.
>>
>> Looks like we simply pushed the xk-c patch too early, assumign that -next
>> will end up in master. But anyway, we've survived 8 years without it, so I
>> think we're good :)
>>
>
> Thank you for the digging I've updated the commit message to reflect
> this info and correct the grammar errors Bastien pointed out. I've
> tried to push this, but it just hangs ? Maybe because I don't have
> write access to xkeyboard-config (it is sitting outside of the
> xorg tree after all) ?
>
> Anyways I'll send a v2 with the improved commit message, if you can push
> that, that would be great.
>
> Regards,
>
> Hans
>
[Attachment #5 (text/html)]
<div dir="ltr">Hi Hans<div><br></div><div>I can push, of course, if the mutual \
consensus is that now is the right time for \
it.</div><div><br></div><div>Cheers</div><div><br></div><div>Sergey</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Mon, May 15, 2017 at 8:26 AM, \
Hans de Goede <span dir="ltr"><<a href="mailto:hdegoede@redhat.com" \
target="_blank">hdegoede@redhat.com</a>></span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">Hi,<span class=""><br> <br>
On 15-05-17 03:06, Peter Hutterer wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> adding svu to CC:<br>
<br>
On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual \
devices and<br> current xproto master defines keysyms for these. Add mappings for<br>
these keys.<br>
<br>
The XF86UWB keysm exists for quite a while now, as does the KEY_SOUND<br>
evdev code for it, so lets adds a mapping for that too.<br>
<br>
Note that this replaces the I255 to XF86Hibernate mapping in<br>
xkb_symbols "evdev", I don't know where that came from, but it is<br>
wrong, I255 was until now not defined in keycodes/evdev and<br>
KEY_HIBERNATE is not defined in linux/input-event-codes.h .<br>
</blockquote>
<br>
see xk-c commit 7b3bfb3ec4b, has a link to the thread. After a bit of<br>
digging, this got merged into dmitry's next tree (see<br>
<a href="https://patchwork.kernel.org/patch/9742/" rel="noreferrer" \
target="_blank">https://patchwork.kernel.org/p<wbr>atch/9742/</a>) but never ended up \
in master.<br> My email archives trail out from there and I'm not sure what \
exactly<br> happens, google isn't forthcoming either.<br>
<br>
Looks like we simply pushed the xk-c patch too early, assumign that -next<br>
will end up in master. But anyway, we've survived 8 years without it, so I<br>
think we're good :)<br>
</blockquote>
<br></span>
Thank you for the digging I've updated the commit message to reflect<br>
this info and correct the grammar errors Bastien pointed out. I've<br>
tried to push this, but it just hangs ? Maybe because I don't have<br>
write access to xkeyboard-config (it is sitting outside of the<br>
xorg tree after all) ?<br>
<br>
Anyways I'll send a v2 with the improved commit message, if you can push<br>
that, that would be great.<br>
<br>
Regards,<br>
<br>
Hans<br>
</blockquote></div><br></div>
[Attachment #6 (text/plain)]
_______________________________________________
xorg-devel@lists.x.org: X.Org development
Archives: http://lists.x.org/archives/xorg-devel
Info: https://lists.x.org/mailman/listinfo/xorg-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic