--===============1325281092==
Content-Type: multipart/alternative; boundary="001a1134ea52be669e054f9150d4"

--001a1134ea52be669e054f9150d4
Content-Type: text/plain; charset="UTF-8"

Hi Hans

I can push, of course, if the mutual consensus is that now is the right
time for it.

Cheers

Sergey

On Mon, May 15, 2017 at 8:26 AM, Hans de Goede <hdegoede@redhat.com> wrote:

> Hi,
>
> On 15-05-17 03:06, Peter Hutterer wrote:
>
>> adding svu to CC:
>>
>> On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote:
>>
>>> KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual devices and
>>> current xproto master defines keysyms for these. Add mappings for
>>> these keys.
>>>
>>> The XF86UWB keysm exists for quite a while now, as does the KEY_SOUND
>>> evdev code for it, so lets adds a mapping for that too.
>>>
>>> Note that this replaces the I255 to XF86Hibernate mapping in
>>> xkb_symbols "evdev", I don't know where that came from, but it is
>>> wrong, I255 was until now not defined in keycodes/evdev and
>>> KEY_HIBERNATE is not defined in linux/input-event-codes.h .
>>>
>>
>> see xk-c commit 7b3bfb3ec4b, has a link to the thread. After a bit of
>> digging, this got merged into dmitry's next tree (see
>> https://patchwork.kernel.org/patch/9742/) but never ended up in master.
>> My email archives trail out from there and I'm not sure what exactly
>> happens, google isn't forthcoming either.
>>
>> Looks like we simply pushed the xk-c patch too early, assumign that -next
>> will end up in master. But anyway, we've survived 8 years without it, so I
>> think we're good :)
>>
>
> Thank you for the digging I've updated the commit message to reflect
> this info and correct the grammar errors Bastien pointed out. I've
> tried to push this, but it just hangs ? Maybe because I don't have
> write access to xkeyboard-config (it is sitting outside of the
> xorg tree after all) ?
>
> Anyways I'll send a v2 with the improved commit message, if you can push
> that, that would be great.
>
> Regards,
>
> Hans
>

--001a1134ea52be669e054f9150d4
Content-Type: text/html; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">Hi Hans<div><br></div><div>I can push, of course, if the m=
utual consensus is that now is the right time for it.</div><div><br></div><=
div>Cheers</div><div><br></div><div>Sergey</div></div><div class=3D"gmail_e=
xtra"><br><div class=3D"gmail_quote">On Mon, May 15, 2017 at 8:26 AM, Hans =
de Goede <span dir=3D"ltr">&lt;<a href=3D"mailto:hdegoede@redhat.com" targe=
t=3D"_blank">hdegoede@redhat.com</a>&gt;</span> wrote:<br><blockquote class=
=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padd=
ing-left:1ex">Hi,<span class=3D""><br>
<br>
On 15-05-17 03:06, Peter Hutterer wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
adding svu to CC:<br>
<br>
On Fri, May 12, 2017 at 04:18:42PM +0200, Hans de Goede wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">
KEY_SOUND, KEY_WWAN and KEY_RFKILL are used on actual devices and<br>
current xproto master defines keysyms for these. Add mappings for<br>
these keys.<br>
<br>
The XF86UWB keysm exists for quite a while now, as does the KEY_SOUND<br>
evdev code for it, so lets adds a mapping for that too.<br>
<br>
Note that this replaces the I255 to XF86Hibernate mapping in<br>
xkb_symbols &quot;evdev&quot;, I don&#39;t know where that came from, but i=
t is<br>
wrong, I255 was until now not defined in keycodes/evdev and<br>
KEY_HIBERNATE is not defined in linux/input-event-codes.h .<br>
</blockquote>
<br>
see xk-c commit 7b3bfb3ec4b, has a link to the thread. After a bit of<br>
digging, this got merged into dmitry&#39;s next tree (see<br>
<a href=3D"https://patchwork.kernel.org/patch/9742/" rel=3D"noreferrer" tar=
get=3D"_blank">https://patchwork.kernel.org/p<wbr>atch/9742/</a>) but never=
 ended up in master.<br>
My email archives trail out from there and I&#39;m not sure what exactly<br=
>
happens, google isn&#39;t forthcoming either.<br>
<br>
Looks like we simply pushed the xk-c patch too early, assumign that -next<b=
r>
will end up in master. But anyway, we&#39;ve survived 8 years without it, s=
o I<br>
think we&#39;re good :)<br>
</blockquote>
<br></span>
Thank you for the digging I&#39;ve updated the commit message to reflect<br=
>
this info and correct the grammar errors Bastien pointed out. I&#39;ve<br>
tried to push this, but it just hangs ? Maybe because I don&#39;t have<br>
write access to xkeyboard-config (it is sitting outside of the<br>
xorg tree after all) ?<br>
<br>
Anyways I&#39;ll send a v2 with the improved commit message, if you can pus=
h<br>
that, that would be great.<br>
<br>
Regards,<br>
<br>
Hans<br>
</blockquote></div><br></div>

--001a1134ea52be669e054f9150d4--

--===============1325281092==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KeG9yZy1kZXZl
bEBsaXN0cy54Lm9yZzogWC5PcmcgZGV2ZWxvcG1lbnQKQXJjaGl2ZXM6IGh0dHA6Ly9saXN0cy54
Lm9yZy9hcmNoaXZlcy94b3JnLWRldmVsCkluZm86IGh0dHBzOi8vbGlzdHMueC5vcmcvbWFpbG1h
bi9saXN0aW5mby94b3JnLWRldmVs

--===============1325281092==--