[prev in list] [next in list] [prev in thread] [next in thread] 

List:       freedesktop-dbus
Subject:    Re: [patch] Make dbus-launch always (if possible) save
From:       Thiago Macieira <thiago () kde ! org>
Date:       2007-11-20 6:49:37
Message-ID: 200711200749.51850.thiago () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


Havoc Pennington wrote:
>- are you sure we didn't do this autolaunch-only on purpose?
>   it doesn't seem like we'd have done this accidentally.
>   it might be worth going through the archived discussion.
>- it would be good if Thiago could review this before commit
>- this code (before you touched it also) is very, very confusing to me
>   for some reason - not sure if it's all the many dbus-launch modes or
>   what... ;-)

I will review it later today.

But yeah, dbus-launch.c is very, very confusing. You can easily get lost 
in the forks and pipes. You lose track of which file descriptors are open 
in which processes. There's also a bizarre ordering of which processes 
are parent of which...

In any case, I do agree that dbus-launch should be simplified. It should 
always save the bus information to file and to X11 (if possible), so that 
autolaunch is also possible. And it shouldn't start a new bus if that 
information is available.

That will make overriding a bit difficult (i.e., intentionally launching a 
second bus daemon).

-- 
  Thiago Macieira  -  thiago (AT) macieira.info - thiago (AT) kde.org
    PGP/GPG: 0x6EF45358; fingerprint:
    E067 918B B660 DBD1 105C  966C 33F5 F005 6EF4 5358

["signature.asc" (application/pgp-signature)]

_______________________________________________
dbus mailing list
dbus@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dbus


[prev in list] [next in list] [prev in thread] [next in thread]