From freedesktop-dbus  Tue Nov 20 06:49:37 2007
From: Thiago Macieira <thiago () kde ! org>
Date: Tue, 20 Nov 2007 06:49:37 +0000
To: freedesktop-dbus
Subject: Re: [patch] Make dbus-launch always (if possible) save
Message-Id: <200711200749.51850.thiago () kde ! org>
X-MARC-Message: https://marc.info/?l=freedesktop-dbus&m=119554141617845
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============0053778245=="

--===============0053778245==
Content-Type: multipart/signed;
  boundary="nextPart16843513.CoDUiMun3N";
  protocol="application/pgp-signature";
  micalg=pgp-sha1
Content-Transfer-Encoding: 7bit

--nextPart16843513.CoDUiMun3N
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

Havoc Pennington wrote:
>- are you sure we didn't do this autolaunch-only on purpose?
>=A0 =A0it doesn't seem like we'd have done this accidentally.
>=A0 =A0it might be worth going through the archived discussion.
>- it would be good if Thiago could review this before commit
>- this code (before you touched it also) is very, very confusing to me
>=A0 =A0for some reason - not sure if it's all the many dbus-launch modes or
>=A0 =A0what... ;-)

I will review it later today.

But yeah, dbus-launch.c is very, very confusing. You can easily get lost=20
in the forks and pipes. You lose track of which file descriptors are open=20
in which processes. There's also a bizarre ordering of which processes=20
are parent of which...

In any case, I do agree that dbus-launch should be simplified. It should=20
always save the bus information to file and to X11 (if possible), so that=20
autolaunch is also possible. And it shouldn't start a new bus if that=20
information is available.

That will make overriding a bit difficult (i.e., intentionally launching a=
=20
second bus daemon).

=2D-=20
=A0 Thiago Macieira =A0- =A0thiago (AT) macieira.info - thiago (AT) kde.org
=A0 =A0 PGP/GPG: 0x6EF45358; fingerprint:
=A0 =A0 E067 918B B660 DBD1 105C =A0966C 33F5 F005 6EF4 5358

--nextPart16843513.CoDUiMun3N
Content-Type: application/pgp-signature; name=signature.asc 
Content-Description: This is a digitally signed message part.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)

iD8DBQBHQoODM/XwBW70U1gRAhoIAKC7kL3g0jbKfTwP4cuNz93eVNEDYQCfVJmJ
6M57TqhewJSdCVTyxG5KfGE=
=R4IU
-----END PGP SIGNATURE-----

--nextPart16843513.CoDUiMun3N--

--===============0053778245==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
dbus mailing list
dbus@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dbus

--===============0053778245==--