[prev in list] [next in list] [prev in thread] [next in thread] 

List:       cfe-commits
Subject:    Re: [PATCH] D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable conc
From:       Richard Smith <richard () metafoo ! co ! uk>
Date:       2015-07-30 1:43:32
Message-ID: 63955a0cd4012298f5183f9bd87a0cc1 () localhost ! localdomain
[Download RAW message or body]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM

Eventually, we'll presumably want separate `isConstexprSpecified` / `isConstexpr` \
functions on `VarDecl` (and `FunctionDecl`), and for the `concept` specifier to imply \
`constexpr`, but that can wait for a separate change.


================
Comment at: lib/Sema/SemaDecl.cpp:9417-9418
@@ +9416,4 @@
+    if (Var->isConcept()) {
+      Diag(Var->getLocation(),
+           diag::err_var_concept_not_initialized);
+      Var->setInvalidDecl();
----------------
Looks like this would fit on one line.


http://reviews.llvm.org/D11600




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits


[prev in list] [next in list] [prev in thread] [next in thread]