From cfe-commits  Thu Jul 30 01:43:32 2015
From: Richard Smith <richard () metafoo ! co ! uk>
Date: Thu, 30 Jul 2015 01:43:32 +0000
To: cfe-commits
Subject: Re: [PATCH] D11600: [CONCEPTS] Add concept to VarDecl and diagnostic for uninitialized variable conc
Message-Id: <63955a0cd4012298f5183f9bd87a0cc1 () localhost ! localdomain>
X-MARC-Message: https://marc.info/?l=cfe-commits&m=143822070300783

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM

Eventually, we'll presumably want separate `isConstexprSpecified` / `isConstexpr` functions on `VarDecl` (and `FunctionDecl`), and for the `concept` specifier to imply `constexpr`, but that can wait for a separate change.


================
Comment at: lib/Sema/SemaDecl.cpp:9417-9418
@@ +9416,4 @@
+    if (Var->isConcept()) {
+      Diag(Var->getLocation(),
+           diag::err_var_concept_not_initialized);
+      Var->setInvalidDecl();
----------------
Looks like this would fit on one line.


http://reviews.llvm.org/D11600




_______________________________________________
cfe-commits mailing list
cfe-commits@cs.uiuc.edu
http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits