'Re: Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 119502: Use unset(..) instead of set(..) to unset CMake variables
From:       "Elvis Stansvik" <elvstone () gmail ! com>
Date:       2014-07-27 17:50:00
Message-ID: 20140727175000.15443.69228 () probe ! kde ! org
[Download RAW message or body]

--===============9102499877161466409==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119502/
-----------------------------------------------------------

(Updated July 27, 2014, 5:49 p.m.)

Review request for Calligra and Friedrich W. H. Kossebau.

Changes
-------

Missed one occurrance due to a bug in my regex. Diff updated.

Repository: calligra

Description (updated)
-------

It's slightly more clear to non-CMake wizards to use `unset(MY_VAR)` instead of \
`set(MY_VAR)` to unset a variable. I found such places with the slightly ugly command

    find . ( -name "*.cmake" -o -name "CMakeLists.txt" ) -exec egrep -Hn \
"(^|\s+)[sS][eE][tT][ ]*([ ]*[^ ]+[ ]*)" {} \;

and changed them to use `unset(..)` instead.

Diffs (updated)
-----

  cmake/modules/FindICU.cmake 46671c8 
  cmake/modules/FindIconv.cmake ce40ab2 
  cmake/modules/FindPoppler.cmake 534acbc 
  cmake/modules/MacroCalligraAddBenchmark.cmake 2178adf 
  krita/CMakeLists.txt 3668a56 
  krita/benchmarks/CMakeLists.txt 86794a5 
  libs/pigment/CMakeLists.txt fb1a54f 
  plugins/colorengines/lcms2/CMakeLists.txt ae4d140 
  cmake/modules/CalligraProductSetMacros.cmake 8b0492b 

Diff: https://git.reviewboard.kde.org/r/119502/diff/

Testing
-------

Did a default CMake run. Everything seemed fine, the semantics should not have \
changed.

Thanks,

Elvis Stansvik

--===============9102499877161466409==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119502/">https://git.reviewboard.kde.org/r/119502/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Calligra and Friedrich W. H. Kossebau.</div>
<div>By Elvis Stansvik.</div>

<p style="color: grey;"><i>Updated July 27, 2014, 5:49 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Missed one occurrance due to a bug in my regex. Diff updated.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
calligra
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description  \
(updated)</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">It's slightly more clear to non-CMake wizards to use \
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: \
normal;margin: 0;line-height: inherit;">unset(MY_VAR)</code> instead of <code \
style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: \
0;line-height: inherit;">set(MY_VAR)</code> to unset a variable. I found such places \
with the slightly ugly command</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" \
style="background: #f8f8f8"><pre style="line-height: 125%">find . <span \
style="border: 1px solid #FF0000">\</span>( <span style="color: #666666">-</span>name \
<span style="color: #BA2121">&quot;*.cmake&quot;</span> <span style="color: \
#666666">-</span>o <span style="color: #666666">-</span>name <span style="color: \
#BA2121">&quot;CMakeLists.txt&quot;</span> <span style="border: 1px solid \
#FF0000">\</span>) <span style="color: #666666">-</span>exec egrep <span \
style="color: #666666">-</span>Hn <span style="color: \
#BA2121">&quot;(^|\s+)[sS][eE][tT][ ]*\([ ]*[^ ]+[ ]*\)&quot;</span> {} <span \
style="border: 1px solid #FF0000">\</span>; </pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">and changed them to use <code style="text-rendering: \
inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: \
inherit;">unset(..)</code> instead.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Did a default CMake run. Everything seemed fine, the \
semantics should not have changed.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>cmake/modules/FindICU.cmake <span style="color: grey">(46671c8)</span></li>

 <li>cmake/modules/FindIconv.cmake <span style="color: grey">(ce40ab2)</span></li>

 <li>cmake/modules/FindPoppler.cmake <span style="color: grey">(534acbc)</span></li>

 <li>cmake/modules/MacroCalligraAddBenchmark.cmake <span style="color: \
grey">(2178adf)</span></li>

 <li>krita/CMakeLists.txt <span style="color: grey">(3668a56)</span></li>

 <li>krita/benchmarks/CMakeLists.txt <span style="color: grey">(86794a5)</span></li>

 <li>libs/pigment/CMakeLists.txt <span style="color: grey">(fb1a54f)</span></li>

 <li>plugins/colorengines/lcms2/CMakeLists.txt <span style="color: \
grey">(ae4d140)</span></li>

 <li>cmake/modules/CalligraProductSetMacros.cmake <span style="color: \
grey">(8b0492b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119502/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============9102499877161466409==--

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 