[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 109002: Turning stage into modebox
From: "Thorsten Zachmann" <t.zachmann () zagge ! de>
Date: 2013-02-18 17:47:12
Message-ID: 20130218174712.21714.1325 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109002/#review27643
-----------------------------------------------------------
libs/kopageapp/KoPAView.cpp
<http://git.reviewboard.kde.org/r/109002/#comment20715>
The bool should be changed to a flag so it easier to add other flags if needed.
libs/kopageapp/KoPAView.cpp
<http://git.reviewboard.kde.org/r/109002/#comment20714>
The if shell() should be moved to the outside of the if as it is used in both so \
only one if will be needed.
libs/kopageapp/tools/backgroundTool/CMakeLists.txt
<http://git.reviewboard.kde.org/r/109002/#comment20717>
These changes look suspisous. What is the reason for those?
libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h
<http://git.reviewboard.kde.org/r/109002/#comment20718>
Why is this export needed?
libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp
<http://git.reviewboard.kde.org/r/109002/#comment20716>
As said in the TODO this should use Slide design in Stage and Page design in \
Flow.
- Thorsten Zachmann
On Feb. 18, 2013, 9:14 a.m., Jean-Nicolas Artaud wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109002/
> -----------------------------------------------------------
>
> (Updated Feb. 18, 2013, 9:14 a.m.)
>
>
> Review request for Calligra and C. Boemann.
>
>
> Description
> -------
>
> Turns stage into modebox.
> Totaly remove the Stroke and Fill docker.
> Add the background fill widget, especialy needed in stage.
>
>
> Diffs
> -----
>
> flow/part/FlowView.cpp b30dbe9
> libs/kopageapp/CMakeLists.txt 35db53f
> libs/kopageapp/KoPAView.h 80b9f78
> libs/kopageapp/KoPAView.cpp 58b4940
> libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui 937e569
> libs/kopageapp/tools/backgroundTool/CMakeLists.txt 339c671
> libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h 45a240f
> libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 69f7649
> libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h cb75621
> libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp b803e79
> libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp c0c5afa
> libs/kopageapp/widgets/KoPABackgroundFillWidget.h PRE-CREATION
> libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp PRE-CREATION
> libs/widgets/KoFillConfigWidget.h 04b185a
> libs/widgets/KoFillConfigWidget.cpp d086eb7
> plugins/dockers/CMakeLists.txt dde9e22
> plugins/dockers/Plugin.cpp 9b6c442
> plugins/dockers/styledocker/StrokeFillWidget.h 212eaa0
> plugins/dockers/styledocker/StrokeFillWidget.cpp d67cabf
> plugins/dockers/styledocker/StyleButtonBox.h e2957fa
> plugins/dockers/styledocker/StyleButtonBox.cpp 291a5af
> plugins/dockers/styledocker/StyleDocker.h 13cf77f
> plugins/dockers/styledocker/StyleDocker.cpp ffec9c4
> plugins/dockers/styledocker/StyleDockerFactory.h acd91ac
> plugins/dockers/styledocker/StyleDockerFactory.cpp 5898610
> plugins/dockers/styledocker/StylePreview.h db33b3f
> plugins/dockers/styledocker/StylePreview.cpp 39f8b42
> plugins/textshape/dialogs/SimpleTableWidget.ui cf9efa0
> stage/part/CMakeLists.txt de57a0f
> stage/part/KPrPageLayoutWidget.h PRE-CREATION
> stage/part/KPrPageLayoutWidget.cpp PRE-CREATION
> stage/part/KPrView.cpp 078b34b
> stage/part/dockers/KPrPageLayoutDocker.h ed7a547
> stage/part/dockers/KPrPageLayoutDocker.cpp e0e3113
>
> Diff: http://git.reviewboard.kde.org/r/109002/diff/
>
>
> Testing
> -------
>
> I played around with the stage-designtool2-boemann branch.
>
>
> Thanks,
>
> Jean-Nicolas Artaud
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109002/">http://git.reviewboard.kde.org/r/109002/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109002/diff/1/?file=114259#file114259line164" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kopageapp/KoPAView.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">KoPAView::KoPAView(KoPart *part, KoPADocument *document, QWidget \
*parent)</pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">163</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">KoPAView</span><span class="o">::</span><span \
class="n">KoPAView</span><span class="p">(</span><span class="n">KoPart</span> <span \
class="o">*</span><span class="n">part</span><span class="p">,</span> <span \
class="n">KoPADocument</span> <span class="o">*</span><span \
class="n">document</span><span class="p">,</span> <span class="n">QWidget</span> \
<span class="o">*</span><span class="n">parent</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">164</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="n">KoPAView</span><span \
class="o">::</span><span class="n">KoPAView</span><span class="p">(</span><span \
class="n">KoPart</span> <span class="o">*</span><span class="n">part</span><span \
class="p">,</span> <span class="n">KoPADocument</span> <span class="o">*</span><span \
class="n">document</span><span class="p">,</span> <span class="kt"><span \
class="hl">bool</span></span><span class="hl"> </span><span class="n"><span \
class="hl">withModeBox</span></span><span class="p"><span \
class="hl">,</span></span><span class="hl"> </span><span class="n">QWidget</span> \
<span class="o">*</span><span class="n">parent</span><span \
class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The bool \
should be changed to a flag so it easier to add other flags if needed.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109002/diff/1/?file=114259#file114259line320" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kopageapp/KoPAView.cpp</a> <span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KoPAView::initGUI()</pre></td> <td colspan="2"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; ">void KoPAView::initGUI(bool withModeBox)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">320</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">if</span> <span class="p">(</span><span class="n">shell</span><span \
class="p">())</span> <span class="p">{</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The if \
shell() should be moved to the outside of the if as it is used in both so only one if \
will be needed.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109002/diff/1/?file=114261#file114261line1" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kopageapp/tools/backgroundTool/CMakeLists.txt</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">include_directories</span><span class="p">(</span> <span \
class="s">../..</span> <span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">1</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">include_directories</span><span class="p">(</span> <span \
class="s">../..</span> <span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">2</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">2</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">3</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">set</span><span class="p">(</span><span \
class="s">kopabackgroundtool_PART_SRCS</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">3</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">set</span><span class="p">(</span><span \
class="s">kopabackgroundtool_PART_SRCS</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">4</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">Plugin.cpp</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">4</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; \
line-height: 140%; margin: 0; "> <span class="s">Plugin.cpp</span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">5</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPABackgroundTool.cpp</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">6</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPABackgroundToolFactory.cpp</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">5</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPABackgroundToolFactory.cpp</span></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">7</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPABackgroundToolWidget.cpp</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">8</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPAMasterPageDocker.cpp</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">6</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPAMasterPageDocker.cpp</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">9</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">)</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">7</font></th> \
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">8</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">11</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">9</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">12</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">kde4_add_ui_files(kopabackgroundtool_PART_SRCS</span></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">13</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="err">BackgroundToolWidget.ui</span></pre></td> <th bgcolor="#ebb1ba" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">14</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">)</span></pre></td> <th bgcolor="#ebb1ba" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th> \
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; \
margin: 0; "></pre></td> </tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">15</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">16</font></th> <td bgcolor="#ffc5ce" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2"></font></th> <td bgcolor="#ffc5ce" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">17</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">kde4_add_plugin(kopabackgroundtool</span> <span \
class="err">${kopabackgroundtool_PART_SRCS})</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">10</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="err">kde4_add_plugin(kopabackgroundtool</span> <span \
class="err">${kopabackgroundtool_PART_SRCS})</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">18</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">11</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">19</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">target_link_libraries</span><span class="p">(</span></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">12</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">target_link_libraries</span><span class="p">(</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">20</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">kopabackgroundtool</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">13</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">kopabackgroundtool</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">21</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">kopageapp</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px \
solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">14</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="s">kopageapp</span></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">22</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">KDE4_KIO_LIBRARY</span><span \
class="o">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">15</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span \
class="nv">KDE4_KIO_LIBRARY</span><span class="o">}</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">23</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">KDE4_PHONON_LIBRARY</span><span \
class="o">}</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">16</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="o">${</span><span \
class="nv">KDE4_PHONON_LIBRARY</span><span class="o">}</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">24</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">)</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">17</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">25</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">18</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">26</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span \
class="s">kopabackgroundtool</span> <span class="s">DESTINATION</span> <span \
class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span \
class="o">}</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">19</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span><span class="s">TARGETS</span> <span \
class="s">kopabackgroundtool</span> <span class="s">DESTINATION</span> <span \
class="o">${</span><span class="nv">PLUGIN_INSTALL_DIR</span><span \
class="o">}</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">27</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">20</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">28</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">21</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">29</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c">########### \
install files ###############</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">22</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="c">########### \
install files ###############</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">30</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">23</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">31</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span> <span class="s">FILES</span> <span \
class="s">kopabackgroundtool.desktop</span> <span class="s">DESTINATION</span> <span \
class="o">${</span><span class="nv">SERVICES_INSTALL_DIR</span><span \
class="o">}</span><span class="p">)</span></pre></td> <th bgcolor="#f0f0f0" \
style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">24</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span> <span class="s">FILES</span> <span \
class="s">kopabackgroundtool.desktop</span> <span class="s">DESTINATION</span> <span \
class="o">${</span><span class="nv">SERVICES_INSTALL_DIR</span><span \
class="o">}</span><span class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">32</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">25</font></th> <td bgcolor="#ffffff" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">26</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">install</span><span class="p">(</span><span \
class="s">FILES</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">27</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">KoPABackgroundTool.h</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">28</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="s">DESTINATION</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">29</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="o">${</span><span class="nv">INCLUDE_INSTALL_DIR</span><span \
class="o">}</span> <span class="s">COMPONENT</span> <span \
class="s">Devel</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="p">)</span></pre></td> </tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">31</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">These \
changes look suspisous. What is the reason for those?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109002/diff/1/?file=114262#file114262line30" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">class \
KoPABackgroundTool : public KoToolBase</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">28</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="n">class</span> \
<span class="n">KoPABackgroundTool</span> <span class="o">:</span> <span \
class="n">public</span> <span class="n">KoToolBase</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">30</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">class</span><span class="hl"> </span><span class="n"><span \
class="hl">KOPAGEAPP_EXPORT</span></span> <span class="n">KoPABackgroundTool</span> \
<span class="o">:</span> <span class="n">public</span> <span \
class="n">KoToolBase</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this \
export needed?</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://git.reviewboard.kde.org/r/109002/diff/1/?file=114265#file114265line32" \
style="color: black; font-weight: bold; text-decoration: \
underline;">libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">32</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"<span class="hl">Document \
background</span>"</span><span class="p">));</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">32</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">setToolTip</span><span class="p">(</span><span class="n">i18n</span><span \
class="p">(</span><span class="s">"<span class="hl">Slide \
design</span>"</span><span class="p">));</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As said in \
the TODO this should use Slide design in Stage and Page design in Flow.</pre> </div>
<br />
<p>- Thorsten</p>
<br />
<p>On February 18th, 2013, 9:14 a.m. UTC, Jean-Nicolas Artaud wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra and C. Boemann.</div>
<div>By Jean-Nicolas Artaud.</div>
<p style="color: grey;"><i>Updated Feb. 18, 2013, 9:14 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Turns stage into modebox. Totaly remove the Stroke and Fill docker.
Add the background fill widget, especialy needed in stage.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I played around with the stage-designtool2-boemann branch.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>flow/part/FlowView.cpp <span style="color: grey">(b30dbe9)</span></li>
<li>libs/kopageapp/CMakeLists.txt <span style="color: grey">(35db53f)</span></li>
<li>libs/kopageapp/KoPAView.h <span style="color: grey">(80b9f78)</span></li>
<li>libs/kopageapp/KoPAView.cpp <span style="color: grey">(58b4940)</span></li>
<li>libs/kopageapp/tools/backgroundTool/BackgroundToolWidget.ui <span style="color: \
grey">(937e569)</span></li>
<li>libs/kopageapp/tools/backgroundTool/CMakeLists.txt <span style="color: \
grey">(339c671)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h <span style="color: \
grey">(45a240f)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp <span style="color: \
grey">(69f7649)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.h <span \
style="color: grey">(cb75621)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolFactory.cpp <span \
style="color: grey">(b803e79)</span></li>
<li>libs/kopageapp/tools/backgroundTool/KoPABackgroundToolWidget.cpp <span \
style="color: grey">(c0c5afa)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/kopageapp/widgets/KoPABackgroundFillWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>libs/widgets/KoFillConfigWidget.h <span style="color: \
grey">(04b185a)</span></li>
<li>libs/widgets/KoFillConfigWidget.cpp <span style="color: \
grey">(d086eb7)</span></li>
<li>plugins/dockers/CMakeLists.txt <span style="color: grey">(dde9e22)</span></li>
<li>plugins/dockers/Plugin.cpp <span style="color: grey">(9b6c442)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.h <span style="color: \
grey">(212eaa0)</span></li>
<li>plugins/dockers/styledocker/StrokeFillWidget.cpp <span style="color: \
grey">(d67cabf)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.h <span style="color: \
grey">(e2957fa)</span></li>
<li>plugins/dockers/styledocker/StyleButtonBox.cpp <span style="color: \
grey">(291a5af)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.h <span style="color: \
grey">(13cf77f)</span></li>
<li>plugins/dockers/styledocker/StyleDocker.cpp <span style="color: \
grey">(ffec9c4)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.h <span style="color: \
grey">(acd91ac)</span></li>
<li>plugins/dockers/styledocker/StyleDockerFactory.cpp <span style="color: \
grey">(5898610)</span></li>
<li>plugins/dockers/styledocker/StylePreview.h <span style="color: \
grey">(db33b3f)</span></li>
<li>plugins/dockers/styledocker/StylePreview.cpp <span style="color: \
grey">(39f8b42)</span></li>
<li>plugins/textshape/dialogs/SimpleTableWidget.ui <span style="color: \
grey">(cf9efa0)</span></li>
<li>stage/part/CMakeLists.txt <span style="color: grey">(de57a0f)</span></li>
<li>stage/part/KPrPageLayoutWidget.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrPageLayoutWidget.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>stage/part/KPrView.cpp <span style="color: grey">(078b34b)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.h <span style="color: \
grey">(ed7a547)</span></li>
<li>stage/part/dockers/KPrPageLayoutDocker.cpp <span style="color: \
grey">(e0e3113)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109002/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic