[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request 108444: Fix cash on creating new character style
From:       Pierre Stirnweiss <pstirnweiss () googlemail ! com>
Date:       2013-01-17 18:08:52
Message-ID: CAOjaSmj45MJ9HTZAekRbYt69X6zpunLxffZOF_6LekFsp7XMzQ () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


yes it's for 2.6, attached a diff with a rebased 2.6

On Thu, Jan 17, 2013 at 6:38 PM, Friedrich W. H. Kossebau
<kossebau@kde.org>wrote:

> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108444/
> 
> Is that for 2.6 or master (bug was for 2.6)? Did not apply cleanly for me against \
> 2.6 at least. 
> 
> - Friedrich W. H.
> 
> On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote:
> Review request for Calligra and Friedrich W. H. Kossebau.
> By Pierre Stirnweiss.
> 
> *Updated Jan. 16, 2013, 8:45 p.m.*
> Description
> 
> When creating a new character style, Words crashed because an null pointer was \
> passed around and used. Also, the name of the style was not updated. 
> *Bugs: * 313233 <http://bugs.kde.org/show_bug.cgi?id=313233>
> Diffs
> 
> - plugins/textshape/dialogs/StylesModel.cpp (80ea48d)
> - plugins/textshape/dialogs/StyleManager.cpp (c561d35)
> - plugins/textshape/dialogs/StyleManager.h (a45a58a)
> - plugins/textshape/dialogs/FormattingPreview.cpp (1ed3b83)
> - plugins/textshape/dialogs/CharacterGeneral.cpp (d3eead6)
> 
> View Diff <http://git.reviewboard.kde.org/r/108444/diff/>
> 


[Attachment #5 (text/html)]

yes it&#39;s for 2.6, attached a diff with a rebased 2.6<br><br><div \
class="gmail_quote">On Thu, Jan 17, 2013 at 6:38 PM, Friedrich W. H. Kossebau <span \
dir="ltr">&lt;<a href="mailto:kossebau@kde.org" \
target="_blank">kossebau@kde.org</a>&gt;</span> wrote:<br>

<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex">



 <div>
  <div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
   <table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" \
width="100%">  <tbody><tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/108444/" \
target="_blank">http://git.reviewboard.kde.org/r/108444/</a>  </td>
    </tr>
   </tbody></table>
   <br>





 </div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">Is \
that for 2.6 or master (bug was for 2.6)? Did not apply cleanly for me against 2.6 at \
least.</pre>


 <br>









<p>- Friedrich W. H.</p><div class="im">


<br>
<p>On January 16th, 2013, 8:45 p.m. UTC, Pierre Stirnweiss wrote:</p>






</div><table style="background-image:url(&#39;&#39;);background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">  \
<tbody><tr>  <td><div class="im">

<div>Review request for Calligra and Friedrich W. H. Kossebau.</div>
<div>By Pierre Stirnweiss.</div>


</div><p style="color:grey"><i>Updated Jan. 16, 2013, 8:45 p.m.</i></p><div \
class="im">






<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
 <table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" \
cellspacing="0" width="100%">  <tbody><tr>
  <td>
   <pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">When \
creating a new character style, Words crashed because an null pointer was passed \
around and used. Also, the name of the style was not updated.</pre>


  </td>
 </tr>
</tbody></table>




<div style="margin-top:1.5em">
 <b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>


 <a href="http://bugs.kde.org/show_bug.cgi?id=313233" target="_blank">313233</a>


</div>


<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">

 <li>plugins/textshape/dialogs/StylesModel.cpp <span \
style="color:grey">(80ea48d)</span></li>

 <li>plugins/textshape/dialogs/StyleManager.cpp <span \
style="color:grey">(c561d35)</span></li>

 <li>plugins/textshape/dialogs/StyleManager.h <span \
style="color:grey">(a45a58a)</span></li>

 <li>plugins/textshape/dialogs/FormattingPreview.cpp <span \
style="color:grey">(1ed3b83)</span></li>

 <li>plugins/textshape/dialogs/CharacterGeneral.cpp <span \
style="color:grey">(d3eead6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/108444/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>







  </div></td>
 </tr>
</tbody></table>








  </div>
 </div>


</blockquote></div><br>

--14dae9cfcea461bfb504d37fe45d--


["patch-fixCrashOnCreateNewCharStyle2" (application/octet-stream)]

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread]