[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request 108448: primitive first version of a QTextDocument inspector docker
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2013-01-17 18:05:56
Message-ID: 20130117180556.4748.34835 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108448/#review25728
-----------------------------------------------------------
Ship it!
Ship It!
- C. Boemann
On Jan. 17, 2013, 4:30 p.m., Friedrich W. H. Kossebau wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108448/
> -----------------------------------------------------------
>
> (Updated Jan. 17, 2013, 4:30 p.m.)
>
>
> Review request for Calligra, C. Boemann and Pierre Stirnweiss.
>
>
> Description
> -------
>
> Having used the WebKit inspector to analyze the structure of HTML documents, I, \
> while looking at the problem with the blocks around tables, had the deep desire to \
> have something similar for QTextDocument objects.
> So here is a patch for the very first simple version of such an inspector:
> * shows the structure of the QTextDocument of the currently selected text shape, \
> i.e. the elements and their names (lists are not detected yet as listed, items only \
> shown as normal blocks)
> * view done as a docker
> * is only build in debug builds, so not part of release builds
>
> Okay to commit to master?
>
> There are many more things one would like to have, but this is a first working \
> intermediate state and maybe useful to some already. And everybody can start to \
> extend it now, as they like/need/got ideas for. So will I :) But for now some \
> feedback is welcome.
>
> Diffs
> -----
>
> plugins/textshape/CMakeLists.txt 672ed29
> plugins/textshape/TextDocumentInspectionDocker.h PRE-CREATION
> plugins/textshape/TextDocumentInspectionDocker.cpp PRE-CREATION
> plugins/textshape/TextDocumentInspectionDockerFactory.h PRE-CREATION
> plugins/textshape/TextDocumentInspectionDockerFactory.cpp PRE-CREATION
> plugins/textshape/TextDocumentStructureModel.h PRE-CREATION
> plugins/textshape/TextDocumentStructureModel.cpp PRE-CREATION
> plugins/textshape/TextPlugin.cpp 9ae621e
>
> Diff: http://git.reviewboard.kde.org/r/108448/diff/
>
>
> Testing
> -------
>
> No crash even with OpenDocument-v1.2-part1.odt, just scrolling in the inspector \
> view was slow, but then this is not optimized yet as there are more important \
> things to do.
>
> File Attachments
> ----------------
>
> View of the inspector
> http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/TextDocument_inspector.png
>
>
> Thanks,
>
> Friedrich W. H. Kossebau
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108448/">http://git.reviewboard.kde.org/r/108448/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre> <br />
<p>- C.</p>
<br />
<p>On January 17th, 2013, 4:30 p.m. UTC, Friedrich W. H. Kossebau wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra, C. Boemann and Pierre Stirnweiss.</div>
<div>By Friedrich W. H. Kossebau.</div>
<p style="color: grey;"><i>Updated Jan. 17, 2013, 4:30 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Having used the WebKit inspector to analyze the structure of HTML \
documents, I, while looking at the problem with the blocks around tables, had the \
deep desire to have something similar for QTextDocument objects.
So here is a patch for the very first simple version of such an inspector:
* shows the structure of the QTextDocument of the currently selected text shape, i.e. \
the elements and their names (lists are not detected yet as listed, items only shown \
as normal blocks)
* view done as a docker
* is only build in debug builds, so not part of release builds
Okay to commit to master?
There are many more things one would like to have, but this is a first working \
intermediate state and maybe useful to some already. And everybody can start to \
extend it now, as they like/need/got ideas for. So will I :) But for now some \
feedback is welcome.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">No crash even with OpenDocument-v1.2-part1.odt, just scrolling in the \
inspector view was slow, but then this is not optimized yet as there are more \
important things to do.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/textshape/CMakeLists.txt <span style="color: grey">(672ed29)</span></li>
<li>plugins/textshape/TextDocumentInspectionDocker.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextDocumentInspectionDocker.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextDocumentInspectionDockerFactory.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextDocumentInspectionDockerFactory.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextDocumentStructureModel.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextDocumentStructureModel.cpp <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>plugins/textshape/TextPlugin.cpp <span style="color: grey">(9ae621e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108448/diff/" style="margin-left: \
3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments \
</h1>
<ul>
<li><a href="http://git.reviewboard.kde.org/media/uploaded/files/2013/01/17/TextDocument_inspector.png">View \
of the inspector</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic