[prev in list] [next in list] [prev in thread] [next in thread]
List: calligra-devel
Subject: Re: Review Request: Make the epub filter handle math formulas
From: "C. Boemann" <cbr () boemann ! dk>
Date: 2012-12-30 5:14:47
Message-ID: 20121230051447.29079.83354 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Dec. 28, 2012, 2:45 p.m., C. Boemann wrote:
> > there is a few places where you have:
> > =
> > if ()
> > {
> > =
> > and one place where there is no {} after if
> > =
> > other than that I've not looked yet - I assume you want moji to review
> =
> Inge Wallin wrote:
> The =
> =
> if ()
> {
> =
> construct is only used where the test is >1 line. If I put the { at =
the end of the line, the first statement inside the brackets will be perfec=
tly aligned with the test. I find that a bit difficult to read, hence this =
way of getting around it.
>
I'm not arguing against the merrits of it. I have personally always preferr=
ed this way of placing braces. However I also think we should follow the ha=
cking style at all times. This way may be easier for you to read but the po=
int of a acking style is that anyone with a minimum of trouble can come in =
and work on the code. After all we are supposed to be an open community.
For case like you desribe I personally write like this (knowing full well t=
hat this is my personal style as well (though not prohibited by the officia=
l style):
if (bla bla bla bla bla bla bla bla bla
bla bla bla bla bla bla bla
bla bla bla bla bla) {
foo;
bar;
}
another way not against the hacking style would be:
if (bla bla bla bla bla bla bla bla bla
bla bla bla bla bla bla bla
bla bla bla bla bla) {
foo;
bar;
}
In the end I don't care all that much about this issue, but will close by s=
aying that the day we do sweeping hacking style cleanups your carefully cra=
fted (and special cased) exceptions would be probably be gone. My variation=
s are more likely not to be touched.
- C.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107969/#review24105
-----------------------------------------------------------
On Dec. 30, 2012, 4:44 a.m., Inge Wallin wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/107969/
> -----------------------------------------------------------
> =
> (Updated Dec. 30, 2012, 4:44 a.m.)
> =
> =
> Review request for Calligra.
> =
> =
> Description
> -------
> =
> This patch implements support for math formulas in the EPUB filter. This =
is the first one of the EPUB3 features that we want to add to Calligra 2.7.
> =
> This version only supports math formulas saved as an embedded document, l=
ike LibreOffice and the OpenOffice variants save it. Calligra saves math fo=
rmulas as inline mathML in the frame, which is not supported by this versio=
n. I thought that I could get some initial feedback while implementing supp=
ort for the Calligra way too.
> =
> =
> Diffs
> -----
> =
> filters/words/epub/OdfParser.cpp 6069b89 =
> filters/words/epub/OdtHtmlConverter.h 68aaffa =
> filters/words/epub/OdtHtmlConverter.cpp e5e0edc =
> filters/words/epub/TODO e634a05 =
> filters/words/epub/exportepub2.cpp cfd50c3 =
> filters/words/epub/exporthtml.cpp 5bb44aa =
> =
> Diff: http://git.reviewboard.kde.org/r/107969/diff/
> =
> =
> Testing
> -------
> =
> Created one simple odt using OOo which has a formula and some text.
> =
> =
> Thanks,
> =
> Inge Wallin
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107969/">http://git.reviewboard.kde.org/r/107969/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On December 28th, 2012, 2:45 p.m., <b>C. \
Boemann</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">there is a few places where you have:
if ()
{
and one place where there is no {} after if
other than that I've not looked yet - I assume you want moji to review</pre>
</blockquote>
<p>On December 30th, 2012, 4:37 a.m., <b>Inge Wallin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The
if ()
{
construct is only used where the test is >1 line. If I put the { at the end of \
the line, the first statement inside the brackets will be perfectly aligned with the \
test. I find that a bit difficult to read, hence this way of getting around it. \
</pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm not arguing \
against the merrits of it. I have personally always preferred this way of placing \
braces. However I also think we should follow the hacking style at all times. This \
way may be easier for you to read but the point of a acking style is that anyone with \
a minimum of trouble can come in and work on the code. After all we are supposed to \
be an open community.
For case like you desribe I personally write like this (knowing full well that this \
is my personal style as well (though not prohibited by the official style):
if (bla bla bla bla bla bla bla bla bla
bla bla bla bla bla bla bla
bla bla bla bla bla) {
foo;
bar;
}
another way not against the hacking style would be:
if (bla bla bla bla bla bla bla bla bla
bla bla bla bla bla bla bla
bla bla bla bla bla) {
foo;
bar;
}
In the end I don't care all that much about this issue, but will close by saying \
that the day we do sweeping hacking style cleanups your carefully crafted (and \
special cased) exceptions would be probably be gone. My variations are more likely \
not to be touched.</pre> <br />
<p>- C.</p>
<br />
<p>On December 30th, 2012, 4:44 a.m., Inge Wallin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>
<p style="color: grey;"><i>Updated Dec. 30, 2012, 4:44 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements support for math formulas in the EPUB filter. This \
is the first one of the EPUB3 features that we want to add to Calligra 2.7.
This version only supports math formulas saved as an embedded document, like \
LibreOffice and the OpenOffice variants save it. Calligra saves math formulas as \
inline mathML in the frame, which is not supported by this version. I thought that I \
could get some initial feedback while implementing support for the Calligra way \
too.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created one simple odt using OOo which has a formula and some \
text.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>filters/words/epub/OdfParser.cpp <span style="color: grey">(6069b89)</span></li>
<li>filters/words/epub/OdtHtmlConverter.h <span style="color: \
grey">(68aaffa)</span></li>
<li>filters/words/epub/OdtHtmlConverter.cpp <span style="color: \
grey">(e5e0edc)</span></li>
<li>filters/words/epub/TODO <span style="color: grey">(e634a05)</span></li>
<li>filters/words/epub/exportepub2.cpp <span style="color: \
grey">(cfd50c3)</span></li>
<li>filters/words/epub/exporthtml.cpp <span style="color: \
grey">(5bb44aa)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107969/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic