'Re: Review Request: Make the epub filter handle math formulas'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Review Request: Make the epub filter handle math formulas
From:       "Inge Wallin" <inge () lysator ! liu ! se>
Date:       2012-12-30 4:44:48
Message-ID: 20121230044448.25887.73240 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/107969/
-----------------------------------------------------------

(Updated Dec. 30, 2012, 4:44 a.m.)

Review request for Calligra.

Changes
-------

Second version:
 - Fix all issues pointed out by reviewers of version 1
 - Implement support for inline math formulas

I consider this code finished now.

Description
-------

This patch implements support for math formulas in the EPUB filter. This is=
 the first one of the EPUB3 features that we want to add to Calligra 2.7.

This version only supports math formulas saved as an embedded document, lik=
e LibreOffice and the OpenOffice variants save it. Calligra saves math form=
ulas as inline mathML in the frame, which is not supported by this version.=
 I thought that I could get some initial feedback while implementing suppor=
t for the Calligra way too.

Diffs (updated)
-----

  filters/words/epub/OdfParser.cpp 6069b89 =

  filters/words/epub/OdtHtmlConverter.h 68aaffa =

  filters/words/epub/OdtHtmlConverter.cpp e5e0edc =

  filters/words/epub/TODO e634a05 =

  filters/words/epub/exportepub2.cpp cfd50c3 =

  filters/words/epub/exporthtml.cpp 5bb44aa =

Diff: http://git.reviewboard.kde.org/r/107969/diff/

Testing
-------

Created one simple odt using OOo which has a formula and some text.

Thanks,

Inge Wallin

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/107969/">http://git.reviewboard.kde.org/r/107969/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Inge Wallin.</div>

<p style="color: grey;"><i>Updated Dec. 30, 2012, 4:44 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">Second version:
 - Fix all issues pointed out by reviewers of version 1
 - Implement support for inline math formulas

I consider this code finished now.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This patch implements support for math formulas in the EPUB filter. This \
is the first one of the EPUB3 features that we want to add to Calligra 2.7.

This version only supports math formulas saved as an embedded document, like \
LibreOffice and the OpenOffice variants save it. Calligra saves math formulas as \
inline mathML in the frame, which is not supported by this version. I thought that I \
could get some initial feedback while implementing support for the Calligra way \
too.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Created one simple odt using OOo which has a formula and some \
text.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>filters/words/epub/OdfParser.cpp <span style="color: grey">(6069b89)</span></li>

 <li>filters/words/epub/OdtHtmlConverter.h <span style="color: \
grey">(68aaffa)</span></li>

 <li>filters/words/epub/OdtHtmlConverter.cpp <span style="color: \
grey">(e5e0edc)</span></li>

 <li>filters/words/epub/TODO <span style="color: grey">(e634a05)</span></li>

 <li>filters/words/epub/exportepub2.cpp <span style="color: \
grey">(cfd50c3)</span></li>

 <li>filters/words/epub/exporthtml.cpp <span style="color: \
grey">(5bb44aa)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/107969/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 