'Review Request: QIcon'ize KoRecentDocumentsPane'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Review Request: QIcon'ize KoRecentDocumentsPane
From:       "Friedrich W. H. Kossebau" <kossebau () kde ! org>
Date:       2012-07-03 22:20:35
Message-ID: 20120703222035.20263.31940 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/105428/
-----------------------------------------------------------

Review request for Calligra.

Description
-------

Real reason for this patch is that KFileItem::pixmap(...) is broken for ite=
ms constructed with KFileItem(mode_t, mode_t, KUrl, bool) and no other mime=
type related call before the one to ::pixmap. It will always return a pixma=
p with the "unknown" icon.
You can see this for files for which there is no preview created (for whate=
ver reason).

But the patch fixes also the size mismatch between the fetched previews (20=
0x200) and the usual ODF preview of 128x128 as well as that the preview jus=
t from the icon is set in size 128. And makes the code shorter.

A more complete patch I have locally also fetches previews in small sizes s=
eparately from the big previews, and those only on demand. That should redu=
ce the memory used in total. But that will come later with the patch to sup=
port templates also from LO folders, this is just for fixing the stuff ment=
ioned above.

Diffs
-----

  libs/main/KoRecentDocumentsPane.cpp 521c7e6 =

Diff: http://git.reviewboard.kde.org/r/105428/diff/

Testing
-------

Thanks,

Friedrich W. H. Kossebau

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px \
#c9c399 solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105428/">http://git.reviewboard.kde.org/r/105428/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px \
black solid;">  <tr>
  <td>

<div>Review request for Calligra.</div>
<div>By Friedrich W. H. Kossebau.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description \
</h1>  <table width="100%" bgcolor="#ffffff" cellspacing="0" \
cellpadding="10" style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Real reason for this patch is that KFileItem::pixmap(...) is \
broken for items constructed with KFileItem(mode_t, mode_t, KUrl, bool) and \
no other mimetype related call before the one to ::pixmap. It will always \
return a pixmap with the &quot;unknown&quot; icon. You can see this for \
files for which there is no preview created (for whatever reason).

But the patch fixes also the size mismatch between the fetched previews \
(200x200) and the usual ODF preview of 128x128 as well as that the preview \
just from the icon is set in size 128. And makes the code shorter.

A more complete patch I have locally also fetches previews in small sizes \
separately from the big previews, and those only on demand. That should \
reduce the memory used in total. But that will come later with the patch to \
support templates also from LO folders, this is just for fixing the stuff \
mentioned above.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/main/KoRecentDocumentsPane.cpp <span style="color: \
grey">(521c7e6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105428/diff/" \
style="margin-left: 3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel

[prev in list] [next in list] [prev in thread] [next in thread] 