--===============4412598303305146024== Content-Type: multipart/alternative; boundary="===============5193007819095344615==" --===============5193007819095344615== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/105428/ ----------------------------------------------------------- Review request for Calligra. Description ------- Real reason for this patch is that KFileItem::pixmap(...) is broken for ite= ms constructed with KFileItem(mode_t, mode_t, KUrl, bool) and no other mime= type related call before the one to ::pixmap. It will always return a pixma= p with the "unknown" icon. You can see this for files for which there is no preview created (for whate= ver reason). But the patch fixes also the size mismatch between the fetched previews (20= 0x200) and the usual ODF preview of 128x128 as well as that the preview jus= t from the icon is set in size 128. And makes the code shorter. A more complete patch I have locally also fetches previews in small sizes s= eparately from the big previews, and those only on demand. That should redu= ce the memory used in total. But that will come later with the patch to sup= port templates also from LO folders, this is just for fixing the stuff ment= ioned above. Diffs ----- libs/main/KoRecentDocumentsPane.cpp 521c7e6 = Diff: http://git.reviewboard.kde.org/r/105428/diff/ Testing ------- Thanks, Friedrich W. H. Kossebau --===============5193007819095344615== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/105428/ |
Review request for Calligra.
By Friedrich W. H. Kossebau.
Descripti= on
Diffs=
|