[prev in list] [next in list] [prev in thread] [next in thread] 

List:       calligra-devel
Subject:    Re: Questions about shape group
From:       Yue Liu <opuspace () gmail ! com>
Date:       2011-05-03 5:21:50
Message-ID: BANLkTim7Wb0vdhAQDMqkRJHPVWa=Vvd6Lg () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


Hello,

Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to
KoCommand, which now becomes
KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to
move it back to KoShapeGroup, what do you think?

https://projects.kde.org/projects/calligra/repository/revisions/fa024de913158d68bd5fe45fb734f28aaf8db74d

On Tue, May 3, 2011 at 1:53 AM, <jaham@gmx.net> wrote:

> On Thursday 28 April 2011 18:02:34 you wrote:
> > Also, I noticed that shadow.Insets is considered when calculating the
> > boundingRect to a shape, is it needed to include the shadow into the
> > boundingRect? And besides calculating boundingRect, where is
> shadow.Insets
> > being used?
>
> Yes the shadow insets are there to expand the bounding rect with the
> shadows
> size so that e.g. canvas updates for that particular shape are calculated
> correctly.
>
> Ciao Jan
>



-- 
Yue Liu

[Attachment #5 (text/html)]

Hello,<br><br>Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() \
to KoCommand, which now becomes KoShapeGroupCommandPrivate::containerBoundingRect(). \
I think now it&#39;s ok to move it back to KoShapeGroup, what do you think?<br> \
<br><a href="https://projects.kde.org/projects/calligra/repository/revisions/fa024de91 \
3158d68bd5fe45fb734f28aaf8db74d">https://projects.kde.org/projects/calligra/repository/revisions/fa024de913158d68bd5fe45fb734f28aaf8db74d</a><br>
 <br><div class="gmail_quote">On Tue, May 3, 2011 at 1:53 AM,  <span dir="ltr">&lt;<a \
href="mailto:jaham@gmx.net">jaham@gmx.net</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex;"> <div><div></div><div class="h5">On Thursday 28 April 2011 \
18:02:34 you wrote:<br> &gt; Also, I noticed that shadow.Insets is considered when \
calculating the<br> &gt; boundingRect to a shape, is it needed to include the shadow \
into the<br> &gt; boundingRect? And besides calculating boundingRect, where is \
shadow.Insets<br> &gt; being used?<br>
<br>
</div></div>Yes the shadow insets are there to expand the bounding rect with the \
shadows<br> size so that e.g. canvas updates for that particular shape are \
calculated<br> correctly.<br>
<br>
Ciao Jan<br>
</blockquote></div><br><br clear="all"><br>-- <br>Yue Liu<br>



_______________________________________________
calligra-devel mailing list
calligra-devel@kde.org
https://mail.kde.org/mailman/listinfo/calligra-devel


[prev in list] [next in list] [prev in thread] [next in thread]