From calligra-devel Tue May 03 05:21:50 2011 From: Yue Liu Date: Tue, 03 May 2011 05:21:50 +0000 To: calligra-devel Subject: Re: Questions about shape group Message-Id: X-MARC-Message: https://marc.info/?l=calligra-devel&m=130440014915631 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2012576448==" --===============2012576448== Content-Type: multipart/alternative; boundary=20cf303dd5ac34af2a04a258512a --20cf303dd5ac34af2a04a258512a Content-Type: text/plain; charset=ISO-8859-1 Hello, Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to KoCommand, which now becomes KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to move it back to KoShapeGroup, what do you think? https://projects.kde.org/projects/calligra/repository/revisions/fa024de913158d68bd5fe45fb734f28aaf8db74d On Tue, May 3, 2011 at 1:53 AM, wrote: > On Thursday 28 April 2011 18:02:34 you wrote: > > Also, I noticed that shadow.Insets is considered when calculating the > > boundingRect to a shape, is it needed to include the shadow into the > > boundingRect? And besides calculating boundingRect, where is > shadow.Insets > > being used? > > Yes the shadow insets are there to expand the bounding rect with the > shadows > size so that e.g. canvas updates for that particular shape are calculated > correctly. > > Ciao Jan > -- Yue Liu --20cf303dd5ac34af2a04a258512a Content-Type: text/html; charset=ISO-8859-1 Hello,

Found that 5 years ago Thomas Zander moved KoShapeGroup::boundingRect() to KoCommand, which now becomes KoShapeGroupCommandPrivate::containerBoundingRect(). I think now it's ok to move it back to KoShapeGroup, what do you think?

https://projects.kde.org/projects/calligra/repository/revisions/fa024de913158d68bd5fe45fb734f28aaf8db74d

On Tue, May 3, 2011 at 1:53 AM, <jaham@gmx.net> wrote:
On Thursday 28 April 2011 18:02:34 you wrote:
> Also, I noticed that shadow.Insets is considered when calculating the
> boundingRect to a shape, is it needed to include the shadow into the
> boundingRect? And besides calculating boundingRect, where is shadow.Insets
> being used?

Yes the shadow insets are there to expand the bounding rect with the shadows
size so that e.g. canvas updates for that particular shape are calculated
correctly.

Ciao Jan



--
Yue Liu
--20cf303dd5ac34af2a04a258512a-- --===============2012576448== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ calligra-devel mailing list calligra-devel@kde.org https://mail.kde.org/mailman/listinfo/calligra-devel --===============2012576448==--