[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets
From:       Michael Tokarev <mjt () tls ! msk ! ru>
Date:       2023-01-21 17:05:44
Message-ID: 1fbeacf6-43d4-e1b1-6ca3-d7a09faf8afc () msgid ! tls ! msk ! ru
[Download RAW message or body]

21.01.2023 19:49, Clément Péron пишет:
> Hi Michael,
> 
> On Sat, 21 Jan 2023 at 16:38, Michael Tokarev <mjt@tls.msk.ru> wrote:
>>
>> A friendly ping?
>>
>> This patch still applies and works okay with current 1.36 version.
> 
> diff --git a/miscutils/lsscsi.c b/miscutils/lsscsi.c
> index 8f7eda761..a9d8c3772 100644
> --- a/miscutils/lsscsi.c
> +++ b/miscutils/lsscsi.c
> @@ -9,6 +9,7 @@
>   //config:config LSSCSI
>   //config:      bool "lsscsi (2.5 kb)"
>   //config:      default y
> +//config:      #depends on PLATFORM_LINUX
> Why is there a '#' here? Should we not drop it?
> 
> same for lspci.c /lsusb.c

These has been there before this PLATFORM_LINUX has been dropped.
It is basically a revert of the previous patch (rebased to current
version). To me, it looks like it weren't clear if these applets
are linux-specific or not, so I decided to keep it this way now, -
we'll know it once others will start using this stuff on other
platforms. Think of it as a documentation, - when you grep for
PLATFORM_LINUX you'll see them. It's trivial to drop these though.

> Maybe add a small comment in the Makefile about the
> .platform.in:

That might be a good idea indeed.

But having in mind the age of this context and the previous attempts
to change it, I'd love to have some feedback for the approach itself,
before adding cosmetics.

I don't like this .platform.in file, - linux-kernel kconfig now has
some variables support so things like that does not require temp
files, but busybox's kconfig is older, so this hack is the only
way to do that which I found. Maybe I'm wrong here.

Either way, this change allowed us to build and use busybox on hurd
and kfreebsd, finally..

/mjt

_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]