[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] buildsys: resurrect PLATFORM_LINUX and depend on it for linux-specific applets
From:       Clément Péron <peron.clem () gmail ! com>
Date:       2023-01-21 16:49:25
Message-ID: CAJiuCccg7_c6_hE_cF3AjRUOjNva5pj2so-OEfM71A3bHWREvQ () mail ! gmail ! com
[Download RAW message or body]

Hi Michael,

On Sat, 21 Jan 2023 at 16:38, Michael Tokarev <mjt@tls.msk.ru> wrote:
>
> A friendly ping?
>
> This patch still applies and works okay with current 1.36 version.

diff --git a/miscutils/lsscsi.c b/miscutils/lsscsi.c
index 8f7eda761..a9d8c3772 100644
--- a/miscutils/lsscsi.c
+++ b/miscutils/lsscsi.c
@@ -9,6 +9,7 @@
 //config:config LSSCSI
 //config:      bool "lsscsi (2.5 kb)"
 //config:      default y
+//config:      #depends on PLATFORM_LINUX
Why is there a '#' here? Should we not drop it?

same for lspci.c /lsusb.c

Maybe add a small comment in the Makefile about the
.platform.in:

Regards,
Clement


>
> Thanks,
>
> /mjt
>
> 04.11.2022 19:49, Michael Tokarev wrote:
> > This effectively reverts the following two commits:
> >
> >    commit e3b1a1fd28558f7a1b3c0ec33313bedb675be8a1
> >    Author: Denys Vlasenko <vda.linux@googlemail.com>
> >    Date:   Sat Feb 26 22:24:08 2011 +0100
> >
> >      Replace "depends on PLATFORM_LINUX" with "select PLATFORM_LINUX"
> >
> > and
> >
> >    commit 5c69ad0ecdc18cf51b312c7c82848f4438fe1c8d
> >    Author: Ron Yorston <rmy@pobox.com>
> >    Date:   Tue Aug 4 08:24:19 2020 +0100
> >
> >      build system: drop PLATFORM_LINUX
> >
> > but does, hopefully, the right thing.
> …
>
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox

[prev in list] [next in list] [prev in thread] [next in thread]