[prev in list] [next in list] [prev in thread] [next in thread] 

List:       busybox
Subject:    Re: [PATCH] - ifupdown.c: remove memory leak
From:       Denys Vlasenko <vda.linux () googlemail ! com>
Date:       2019-04-28 15:55:56
Message-ID: CAK1hOcOkH4O1CXg6UxifErQEPsnW_WoU7c0mTAnFfLwyAyqDZA () mail ! gmail ! com
[Download RAW message or body]

Fixed in a bit different way.

On Sun, Apr 28, 2019 at 5:09 PM Chloe Kudryavtsev <toast@toastin.space> wrote:
>
> This has been in the tree for a pretty long time, and usually
> `if{up,down} -a` is a short-lived process.
>
> Generally speaking, no memory leak > memory leak (even in short lived
> processes).
>
> The extra integer (typically) takes up 4 bytes, but gets freed off the
> stack.
> Relative to leaking (even a bit) for every interface, it's likely
> preferable in memory constrained environments.
>
> I've done minimal testing (making sure `ifup -a` and `ifdown -a` run
> with the patch applied), but given the nature of the patch I cannot
> foresee it introducing a new bug.
> _______________________________________________
> busybox mailing list
> busybox@busybox.net
> http://lists.busybox.net/mailman/listinfo/busybox
_______________________________________________
busybox mailing list
busybox@busybox.net
http://lists.busybox.net/mailman/listinfo/busybox
[prev in list] [next in list] [prev in thread] [next in thread]